Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rosidl_runtime_cpp headers that are called rosidl_typesupport_cpp for REP 122 #673

Open
sloretz opened this issue Mar 29, 2022 · 1 comment

Comments

@sloretz
Copy link
Contributor

sloretz commented Mar 29, 2022

rosidl_runtime_cpp includes the headers

  • rosidl_typesuport_cpp/action_type_support.hpp
  • rosidl_typesuport_cpp/message_type_support.hpp
  • rosidl_typesuport_cpp/service_type_support.hpp

https://github.com/ros2/rosidl/tree/master/rosidl_runtime_cpp/include/rosidl_typesupport_cpp

but this naming is contrary to REP 122 and confusing because there's also a rosidl_typesupport_cpp package with its own installed headers.

I think these should be moved into the rosidl_runtme_cpp/ folder instead.

@sloretz
Copy link
Contributor Author

sloretz commented Mar 29, 2022

It looks like the headers didn't get renamed #442 (comment) to get a PR in without making too many changes.

@clalancette clalancette added this to To do in Iron Irwini via automation Apr 14, 2022
@clalancette clalancette removed this from To do in Iron Irwini Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant