Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy: Also deploy for tag runs? #277

Open
pat-s opened this issue Jul 18, 2020 · 1 comment
Open

Deploy: Also deploy for tag runs? #277

pat-s opened this issue Jul 18, 2020 · 1 comment

Comments

@pat-s
Copy link
Member

pat-s commented Jul 18, 2020

Currently we don't push in tag builds:

tic/R/steps-git.R

Lines 251 to 254 in 1228a73

check = function() {
!ci_is_tag()
},

This does not play well with {fledge} and its automated release workflow since the run containing the release version (e.g. 0.3.0) is only run on a tag build (and not on a normal master push).
Hence, the pkgdown site is not deployed for this build, which leaves an automated release/version pkgdown site in an old state.

@krlmlr Is there any reason why we should not push for tag builds?

@pat-s
Copy link
Member Author

pat-s commented Aug 27, 2020

ping @krlmlr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant