Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-agnostic way to display logs on failure #19

Open
krlmlr opened this issue Jun 17, 2017 · 5 comments
Open

CI-agnostic way to display logs on failure #19

krlmlr opened this issue Jun 17, 2017 · 5 comments
Labels

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 17, 2017

Travis CI: Default to print to job log
AppVeyor: Capable of hosting artifacts

@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 28, 2018

Push artifacts to an orphan branch, tag it, print link to console.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Aug 13, 2018

Can be achieved (mostly) with existing code, create a demo package to illustrate this.

  • step_rcmdcheck() needs to keep check output (optionally or only when failing)
  • setup SSH keys for the "after_failure" stage, use a branch name generated from ci()$get_build_number()

Orphan branches are problematic because they will be downloaded by default when the user does git fetch . But maybe that's not much of a problem if only logs for failed builds are pushed.

@pat-s pat-s added the feature label Aug 13, 2018
@pat-s pat-s added this to the v1.0.0 (CRAN) milestone Aug 13, 2018
@krlmlr krlmlr removed this from the v1.0.0 (CRAN) milestone Mar 31, 2019
@pat-s
Copy link
Member

pat-s commented Nov 28, 2019

Do we really want this? Aren't we fine with uploading artifacts to the CI provider and having this set in the default templates we're shipping?

@krlmlr
Copy link
Collaborator Author

krlmlr commented Nov 28, 2019

Maybe we can make AppVeyor uploads work again?

@pat-s
Copy link
Member

pat-s commented Nov 28, 2019

Yes, we should/could do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants