Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete example in get started vignette for fun global_search() #112

Open
salvafern opened this issue Jun 23, 2023 · 3 comments
Open

Comments

@salvafern
Copy link

Hello there 馃憢

I just noticed there is an incomplete example in the get started vignette:

global_search(query, server_list, which_service)
#> Error in check_arg(query, "character"): object 'query' not found

https://docs.ropensci.org/rerddap/reference/global_search.html

But I also saw this error message is hard coded in

#> Error in check_arg(query, "character"): object 'query' not found
so not sure if this is intentional.

In any case I made a quick fix (salvafern@8b6db96), happy to PR if you agree.

Thanks for this great package!
Salva

@rmendels
Copy link
Collaborator

@salvafern Thanks for pointing out this error. I see the error, I am not good with git would prefer making the change myself directly. Fortunately I am going to be making a new commit to CRAN some time next week. Can you tell me your name and email so I can add you as a contributor? Send it to my work email if you prefer.

And glad you like the package. We make a real effort to allow folks to easily access the data they need in their work.

@rmendels
Copy link
Collaborator

@salvafern Looking at this I think originally I meant the R chunk to be set not to execute, but goofed on that, I will likely use your example.

@salvafern
Copy link
Author

Info sent by email, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants