Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Linting changes: Allow user to set behavior of linting, Use geojsonlint? #52

Open
sckott opened this issue Oct 18, 2016 · 4 comments
Open
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Oct 18, 2016

@jhollist @ateucher

  1. In discussing the right hand rule, i noticed that our linting functionality in lawn always stops when the linter fails. Should we allow user to toggle this behavior to stop or simply warn when it fails?
  2. should we depend on geojsonlint R pkg (which is now on cran)? instead of using the js library geojsonhint - which is one of the options in geojsonlint R pkg (others are geojsonlint web API and geojson schema validation via is-my-json-valid JS library)
@sckott sckott added this to the v0.2 milestone Oct 18, 2016
@ateucher
Copy link

Tricky, because I'd think in some cases you'd want it to fail, and in some (such as the winding issue), passing with a warning should suffice. But I don't know if there is that much granularity in the linter output?

I would think depending on geojsonlint R package makes sense, so you've not duplicating functionality. In rmapshaper I'm kind of toying with the idea of getting rid of linting altogether and letting the user worry about it... Maybe include geojsonhint in Suggests and show its use in some examples?

@jhollist
Copy link
Collaborator

I'm just now learning about linting, so I'll leave this to the both of you to decide...

@sckott
Copy link
Contributor Author

sckott commented Oct 19, 2016

okay, thanks jeff

@sckott sckott modified the milestones: v0.3, v0.2 Oct 24, 2016
@sckott
Copy link
Contributor Author

sckott commented Oct 24, 2016

Going to push this off until the next milestone.

Sorta complex. If we import geojsonlint, then that will require installing httr, not a huge deal, but kinda silly given we don't need to make http requests otherwise.

I think i remember wanting to keep linting at some point because errors returned from turf weren't always useful, but then again, the user can always do that themselves.

@sckott sckott modified the milestones: v0.5, v0.4 Jun 14, 2017
@sckott sckott modified the milestones: v0.5, v1.0 Jan 31, 2019
@sckott sckott modified the milestones: v0.6, v1.0 Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants