You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2022. It is now read-only.
In discussing the right hand rule, i noticed that our linting functionality in lawn always stops when the linter fails. Should we allow user to toggle this behavior to stop or simply warn when it fails?
should we depend on geojsonlint R pkg (which is now on cran)? instead of using the js library geojsonhint - which is one of the options in geojsonlint R pkg (others are geojsonlint web API and geojson schema validation via is-my-json-valid JS library)
The text was updated successfully, but these errors were encountered:
Tricky, because I'd think in some cases you'd want it to fail, and in some (such as the winding issue), passing with a warning should suffice. But I don't know if there is that much granularity in the linter output?
I would think depending on geojsonlint R package makes sense, so you've not duplicating functionality. In rmapshaper I'm kind of toying with the idea of getting rid of linting altogether and letting the user worry about it... Maybe include geojsonhint in Suggests and show its use in some examples?
Sorta complex. If we import geojsonlint, then that will require installing httr, not a huge deal, but kinda silly given we don't need to make http requests otherwise.
I think i remember wanting to keep linting at some point because errors returned from turf weren't always useful, but then again, the user can always do that themselves.
@jhollist @ateucher
lawn
always stops when the linter fails. Should we allow user to toggle this behavior to stop or simply warn when it fails?geojsonlint
R pkg (which is now on cran)? instead of using the js librarygeojsonhint
- which is one of the options ingeojsonlint
R pkg (others are geojsonlint web API and geojson schema validation viais-my-json-valid
JS library)The text was updated successfully, but these errors were encountered: