Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gtk doesn't correctly handle transfer-full, in argument #304

Open
peat-psuwit opened this issue Jun 18, 2021 · 0 comments
Open

node-gtk doesn't correctly handle transfer-full, in argument #304

peat-psuwit opened this issue Jun 18, 2021 · 0 comments

Comments

@peat-psuwit
Copy link
Contributor

While investing some code for #302, I noticed that node-gtk doesn't seem to take argument's transfer mode into account while filing GIArgument. So, I wrote a test case to test that, and it seems like it's the case.

    let gstPromise = new Gst.Promise();
    let structure = Gst.Structure.newEmpty('test');
    gstPromise.reply(structure); // gstPromise now owns backing GstStructure.

    gstPromise = null;
    global.gc();

    // Causes an assertion and return false
    console.log(structure.isEqual(structure));

I've turned this into a test case for node-gtk in #303, so when it's fixed, there will be a test case ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant