Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AutoRegistration #607

Open
solnic opened this issue Jun 25, 2020 · 0 comments
Open

Improve AutoRegistration #607

solnic opened this issue Jun 25, 2020 · 0 comments
Assignees
@solnic
Labels
core feature
Milestone
6.0.0

Comments

@solnic
Copy link
Member

solnic commented Jun 25, 2020

Reporting this as a placeholder for now. Specific improvements are TBD.
@solnic solnic added this to the 6.0.0 milestone Jun 25, 2020
@solnic solnic self-assigned this Jun 25, 2020
solnic added a commit that referenced this issue Jun 11, 2021
@solnic
Use Zeitwerk for loading components
2d9f2f2 
- Replace AutoRegistration with a new Loader that uses Zeitwerk
- Remove support for non-standard setups where dir structure doesn't
  match namespaces
- Deprecate `ROM::Setup#auto_registration` and move it to `rom/compat`

Refs #607
solnic added a commit that referenced this issue Jun 12, 2021
@solnic
Use Zeitwerk for loading components
69046a0 
- Replace AutoRegistration with a new Loader that uses Zeitwerk
- Remove support for non-standard setups where dir structure doesn't
  match namespaces
- Deprecate `ROM::Setup#auto_registration` and move it to `rom/compat`

Refs #607
solnic added a commit that referenced this issue Jun 12, 2021
@solnic
Use Zeitwerk for loading components
f9fc522 
- Replace AutoRegistration with a new Loader that uses Zeitwerk
- Deprecate `ROM::Setup#auto_registration` and move it to `rom/compat`

Refs #607
solnic added a commit that referenced this issue Jun 13, 2021
@solnic
Use Zeitwerk for loading components (#634)
458fb20 
[changelog]

added:
- "Backward-compatibility extension that you can load via `require "rom/compat"` (via #634 refs #607) (@solnic)"
changed:
- "[BREAKING] `Setup#auto_registration` was renamed to `Setup#auto_register`. You can restore the original method via rom/compat extension (via #634 refs #607) (@solnic)"
- "[internal] auto registration is now powered by Zeitwerk (via #634 refs #607) (@solnic)"
@solnic solnic mentioned this issue Jun 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solnic solnic

Labels
core feature
Projects
rom-rb 6.0
Status: Backlog
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@solnic