Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for config loader assembly in bin subfolder #640

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jacob-ewald
Copy link

Description of the change

In some .Net projects the assemblies are output to the "bin" subfolder, and the execution context is in the parent folder. This change checks for the existence of the "bin" folder and uses that when present.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@jacob-ewald
Copy link
Author

There are 3 failed tests, but they are not related to the change I made. Any guidance on how to handle those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollbarConfigurationLoader searches in wrong directory
1 participant