Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open issues pnorman's version #3

Open
16 of 17 tasks
roelderickx opened this issue Apr 25, 2021 · 4 comments
Open
16 of 17 tasks

Open issues pnorman's version #3

roelderickx opened this issue Apr 25, 2021 · 4 comments

Comments

@roelderickx
Copy link
Owner

roelderickx commented Apr 25, 2021

@roelderickx
Copy link
Owner Author

pnorman#56

@mr-greenjeans +1 for the completeness of your bug report and the investigation you have done already. Thanks!
You correctly identified a bug and it will be fixed in the next version, which will be in this fork since maintenance has ceased on pnorman's version. I will think about a good way to implement the fix, your patch is technically correct but it is not the most elegant solution.

@roelderickx
Copy link
Owner Author

pnorman#47

@joaokho After closer inspection this turns out to be the same issue as above. Thanks for reporting!

@roelderickx
Copy link
Owner Author

pnorman#22

I am not sure if the encoding can be detected for any ogr datasource, if it is not UTF-8 it must be specified by the encoding parameter. Ogr2osm will then try to interpret the file with the given encoding, it is up to the user to know or guess how the source file is encoded.
Even though the standard for shapefiles is Latin-1 it is possible to create such a file with any other encoding. However, for KML files this is not possible, the driver included in GDAL can only handle UTF-8 no matter how the encoding is defined on the first line.
Because human-readable source files are preferable over binary shapefiles and KML is not an option, the encoding testcases have been replaced by geojson files, for which GDAL accepts any encoding.

@grischard
Copy link

grischard commented Jul 7, 2021

Hey, I'd given up hope on some of these. Many thanks, @roelderickx! This will be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants