Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about sample_update.cc #50

Open
jianingwangind opened this issue Mar 13, 2019 · 1 comment
Open

question about sample_update.cc #50

jianingwangind opened this issue Mar 13, 2019 · 1 comment

Comments

@jianingwangind
Copy link

in function update_sample_space_model in case "if memory is full", I got confused about the prior weights renormalization step. why the loop is controlled by i < prior_weights_[i] instead of i < prior_weights_.size().
I cant see the meaning of the former one. I am looking forward to your reply:)

@jianingwangind
Copy link
Author

jianingwangind commented Mar 13, 2019

also there is a step to ensure that the sample with higher prior weight is assigned id1. I think here you need
prior_weights_[closest_exist_sample_pair.y] >prior_weights_[closest_exist_sample_pair.x] instead of prior_weights_[closest_exist_sample_pair.x] >prior_weights_[closest_exist_sample_pair.y]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant