From 6a34355905ab65cc82fb3dd9f071fcaa059c5839 Mon Sep 17 00:00:00 2001 From: Maxime Fabre Date: Thu, 21 Jul 2016 10:41:48 +0200 Subject: [PATCH] Close #681 - Fixed some tasks having their after event not fire --- CHANGELOG.md | 1 + src/Rocketeer/Tasks/Check.php | 2 +- src/Rocketeer/Tasks/Deploy.php | 2 +- src/Rocketeer/Tasks/Rollback.php | 3 ++- src/Rocketeer/Tasks/Teardown.php | 2 +- src/Rocketeer/Tasks/Update.php | 2 +- 6 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f4cc7d466..fc0da7537 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ Rocketeer follows the [Semantic Versioning 2.0](http://semver.org/spec/v2.0.0.ht ### Fixed - Fixed remote storage being written to in pretend mode - Fixed `StepsRunner` not halting the running of steps upon encountering a strict false +- Fixed some tasks having their `after` event not firing ## [2.2.1] - 2016-07-10 diff --git a/src/Rocketeer/Tasks/Check.php b/src/Rocketeer/Tasks/Check.php index 624b4765e..70b80b01f 100644 --- a/src/Rocketeer/Tasks/Check.php +++ b/src/Rocketeer/Tasks/Check.php @@ -83,7 +83,7 @@ public function execute() } // Display confirmation message - $this->explainer->line('Your server is ready to deploy'); + return $this->explainer->line('Your server is ready to deploy'); } //////////////////////////////////////////////////////////////////// diff --git a/src/Rocketeer/Tasks/Deploy.php b/src/Rocketeer/Tasks/Deploy.php index db4f56eba..201dabd4b 100644 --- a/src/Rocketeer/Tasks/Deploy.php +++ b/src/Rocketeer/Tasks/Deploy.php @@ -79,7 +79,7 @@ public function execute() $this->releasesManager->markReleaseAsValid($release); - $this->explainer->line('Successfully deployed release '.$release); + return $this->explainer->line('Successfully deployed release '.$release); } //////////////////////////////////////////////////////////////////// diff --git a/src/Rocketeer/Tasks/Rollback.php b/src/Rocketeer/Tasks/Rollback.php index 74deae200..bd5a08c1c 100644 --- a/src/Rocketeer/Tasks/Rollback.php +++ b/src/Rocketeer/Tasks/Rollback.php @@ -56,8 +56,9 @@ public function execute() } // Rollback release - $this->explainer->success('Rolling back to release '.$rollbackRelease); $this->updateSymlink($rollbackRelease); + + return $this->explainer->success('Rolling back to release '.$rollbackRelease); } //////////////////////////////////////////////////////////////////// diff --git a/src/Rocketeer/Tasks/Teardown.php b/src/Rocketeer/Tasks/Teardown.php index f61866f77..4c22b8cc0 100644 --- a/src/Rocketeer/Tasks/Teardown.php +++ b/src/Rocketeer/Tasks/Teardown.php @@ -53,6 +53,6 @@ public function execute() // Remove deployments file $this->localStorage->destroy(); - $this->command->info('The application was successfully removed from the remote servers'); + return $this->command->info('The application was successfully removed from the remote servers'); } } diff --git a/src/Rocketeer/Tasks/Update.php b/src/Rocketeer/Tasks/Update.php index ae51f0f06..cf9c89660 100644 --- a/src/Rocketeer/Tasks/Update.php +++ b/src/Rocketeer/Tasks/Update.php @@ -65,6 +65,6 @@ public function execute() $this->artisan()->runForCurrentRelease('clearCache'); } - $this->command->info('Successfully updated application'); + return $this->command->info('Successfully updated application'); } }