Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are files in the legacy directory mantained? #23

Open
traversaro opened this issue Sep 4, 2021 · 3 comments
Open

Are files in the legacy directory mantained? #23

traversaro opened this issue Sep 4, 2021 · 3 comments
Assignees

Comments

@traversaro
Copy link
Member

I noticed that those files contained a [VELOCITY_CONTROL] group that will stop working in gazebo-yarp-plugins 4 once the velocityControlImplementationType parameter, introduced in gazebo-yarp-plugins v3.5.1 https://github.com/robotology/gazebo-yarp-plugins/blob/master/CHANGELOG.md#351---2020-10-05 , will be made compulsory instead of automatically use the default value direct_velocity_pid. If those files are not mantained, why we don't just tag a release that contains them, and then remove them from the master branch of the repo?

@traversaro
Copy link
Member Author

Related to robotology/gazebo-yarp-plugins#577 .

@lrapetti lrapetti self-assigned this Sep 6, 2021
@lrapetti lrapetti added this to the AnDy - Iteration 69 milestone Sep 6, 2021
@lrapetti
Copy link
Member

lrapetti commented Sep 6, 2021

Files in legacy are no longer maintained, I think we can proceed to remove them as you were mentionaing.

@lrapetti
Copy link
Member

@MarcoCaianiello is currently working on those files. Indeed rather then deprecating them, we could revive it by pushing the updated, and working, configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants