Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove teleoperation models for icub2.5 and icub3 #343

Open
lrapetti opened this issue Mar 13, 2023 · 2 comments
Open

Remove teleoperation models for icub2.5 and icub3 #343

lrapetti opened this issue Mar 13, 2023 · 2 comments
Assignees

Comments

@lrapetti
Copy link
Member

The objective is to get rid of the teleoperation models found in https://github.com/robotology/human-dynamics-estimation/tree/master/conf/urdfs which are copies of the original robot urdf files (contained in https://github.com/robotology/icub-models) with the addition of fake links originally added to replicate the orientation of the sensors data.

Those links added to the urdfs are no longer necessary after #254.

In fact, for example, the ergoCub model was added and tested (#340) by using directly the original model by adding all the required fixed transforms to the configuration file (see

<group name="MEASUREMENT_TO_LINK_TRANSFORMS">
<param name="target_LeftHand">( 1.0 0.0 0.0 0.0
0.0 0.0 1.0 -0.02
0.0 -1.0 0.0 0.05
0.0 0.0 0.0 1.0)</param>
<param name="target_RightHand">(-1.0 0.0 0.0 0.0
0.0 0.0 1.0 -0.02
0.0 1.0 0.0 0.05
0.0 0.0 0.0 1.0)</param>
<param name="target_Head">( 0.0 -1.0 0.0 0.0
0.0 0.0 1.0 0.0
-1.0 0.0 0.0 0.1
0.0 0.0 0.0 1.0)</param>
<param name="target_Chest">( 0.0 1.0 0.0 0.0
0.0 0.0 1.0 0.0
1.0 0.0 0.0 0.0
0.0 0.0 0.0 1.0)</param>
<param name="target_r_upper_arm">( 1.0 0.0 0.0 0.0
0.0 0.0 1.0 0.0
0.0 -1.0 0.0 0.0
0.0 0.0 0.0 1.0)</param>
<param name="target_l_upper_arm">( 1.0 0.0 0.0 0.0
0.0 0.0 -1.0 0.0
0.0 1.0 0.0 0.0
0.0 0.0 0.0 1.0)</param>
<param name="target_r_forearm">( 1.0 0.0 0.0 0.0
0.0 0.0 1.0 0.0
0.0 -1.0 0.0 0.0
0.0 0.0 0.0 1.0)</param>
<param name="target_l_forearm">( 1.0 0.0 0.0 0.0
0.0 0.0 -1.0 0.0
0.0 1.0 0.0 0.0
0.0 0.0 0.0 1.0)</param>
</group>
). Since the ergoCub model should basically have same (or similar) link definition as the iCub3 (and iCub2.5) models, starting from those transforms we should be able to get rid of the teleoperation models.

cc @mebbaid @S-Dafarra

@S-Dafarra
Copy link
Contributor

S-Dafarra commented Mar 13, 2023

Since the ergoCub model should basically have same (or similar) link definition as the iCub3 (and iCub2.5) models, starting from those transforms we should be able to get rid of the teleoperation models.

I remember that with @GiulioRomualdi we had some issues in understanding the frame wrt which the offset was defined (the rotation part was clearer). When using the offsets of iCub3 (

<param name="target_LeftHand">( 1.0 0.0 0.0 0.0
0.0 -1.0 0.0 0.025
0.0 0.0 -1.0 0.15
0.0 0.0 0.0 1.0)</param>
<param name="target_RightHand">(-1.0 0.0 0.0 0.0
0.0 1.0 0.0 0.025
0.0 0.0 -1.0 0.15
0.0 0.0 0.0 1.0)</param>
) we did not have the expected effect on ergoCub.

@lrapetti
Copy link
Member Author

I noticed that we are also maintaining some files for whole-body retargeting (e.g. https://github.com/robotology/human-dynamics-estimation/blob/master/conf/xml/RobotStateProvider_iCub2_5.xml) so in order to get rid of the teleoperation model we should also add the fixed transform for the leg frames (so it's not simply about copying ergoCub configuration files).

One option might be to remove those configuration for whole-body retargeting since they are currently not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants