Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow listeners to remove log messages altogether #5089

Open
pekkaklarck opened this issue Mar 22, 2024 · 3 comments
Open

Allow listeners to remove log messages altogether #5089

pekkaklarck opened this issue Mar 22, 2024 · 3 comments

Comments

@pekkaklarck
Copy link
Member

Listeners using the v3 API can modify the logged message, but they cannot remove it altogether. Even if they set the message to an empty string, that empty string is still logged. This adds unnecessary noise to the log file and increases the size of output.xml.

This is easiest to implement by ignoring log messages having an empty string as the value. Not writing them to output.xml is easy and that automatically takes care of removing them from the log file as well. They should not be included in the result model created during execution either, but I actually believe that model doesn't get log messages at all at the moment.

@Meet2rohit99
Copy link

@pekkaklarck , i am new to this repo and would like to fix this issue. could you please assign this to me.

@OukhellouFst
Copy link

@pekkaklarck, I'm currently working with Robotframework to do E2E testing for our application. I'll be glad to fix this simple issue

@pekkaklarck
Copy link
Member Author

Anyone is free to create a pull request with the fix and needed tests. Assuming we implement this simply by not writing empty messages to output.xml, the implementation is pretty easy. Creating a test isn't hard either, but requires being familiar with Robot's acceptance test system and designing where to add the test.

Do you @Meet2rohit99 and @OukhellouFst want to agree who tries to create a PR first or do you both want to do it? I'm happy to review PRs either way and can also help otherwise if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants