New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractSSHClient login is crashing, if keep_alive_interval is not given as argument #396
Comments
Hello @Thonuck ! Thank you for opening an issue. Unfortunately, I was not able to replicate the issue as Thank you kindly for your involvement and please let me know if I misunderstood your problem. |
Sorry, I did not see your reply earlier. Here is my more detailed findings: If you look at the login function of the AbstractSSHClient, you have:
where keep_alive_interval is set by default to None
which is then conform with
But this leads to So this will always run in a TypeError, if the value is not given here. Unfortunately, I'm not able to reproduce the use case right now, that this situation occurred. But maybe setting in general the default value for keep_alive_interval to 0 in the argument list of "login" avoids this situation to occur again. |
Hi, @Thonuck! That being said, I do consider that there isn't any reason why keep_alive_interval should not be a valid value in the other function definitions, and such I have made a pull request with the specified changes #408 . Thank you for your cooperation and involvement! |
If you call the login and no keep_alive_interval, then the keep_alive_inteval is set to None,
with this the following line will not work:
(line 203) keep_alive_interval = int(TimeEntry(keep_alive_interval).value)
The text was updated successfully, but these errors were encountered: