Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serving multiple libraries by one server #19

Open
pekkaklarck opened this issue Mar 18, 2014 · 17 comments
Open

Support serving multiple libraries by one server #19

pekkaklarck opened this issue Mar 18, 2014 · 17 comments
Milestone

Comments

@pekkaklarck
Copy link
Member

This would obviously ease hosting multiple libraries considerably. jrobotremoteserver by @ombre42 already handles this.

@pekkaklarck pekkaklarck added this to the 1.1 milestone Mar 18, 2014
@wrightj5
Copy link

Hi there,

Do you have an estimated time of delivery for this change?

Regards,

Jw

@pekkaklarck
Copy link
Member Author

Unfortunately I doubt I have time look at this in the near future. Getting RF 2.8.5 out and then starting RF 2.9 is likely more important for my main client. Sponsoring the development or providing a pull request would obviously fasten the development. Let me know if you are interested in either of them and we can agree on details.

@userzimmermann
Copy link

Hi. My robotframework-tools contain an extended RobotRemoteServer which has multiple library support and other additional features:

https://github.com/userzimmermann/robotframework-tools#4-using-robot-framework-remotely

@samratashok87
Copy link

So with Robot Remote server we can host multiple libraries ?

@pekkaklarck
Copy link
Member Author

@userzimmermann: Cool! Interested to provide a pr here too?

@userzimmermann
Copy link

@samratashok87 Hi. Thanks for your interest. And sorry for the late answer :)
Yes. By installing my https://github.com/zimmermanncode/robotframework-tools you can do that by following the explanation at https://github.com/zimmermanncode/robotframework-tools#4-using-robot-framework-remotely
Among some additional features also explained there.
But be aware that my project is still in an alpha stage and has still compatibility issues with Robot Framework 3.0.

@pekkaklarck Nice that you are also interested in that stuff :) Regarding a PR: Honestly, I don't want to put effort into extracting my derived RemoteRobot layer from my robottools package for direct integration into robotremoteserver. It is too much linked to other components of my package. Everyone can use it from my package, and I am already working on full Robot 3.0 compatibility of the whole project.

@pekkaklarck pekkaklarck modified the milestones: 1.2, 1.1 Jan 9, 2017
@zeinababbasi
Copy link

I have made some changes in the project to accept multiple libraries on a new branch. I don't have permission on the project to push. This is my own repository:
https://github.com/zeinababbasi/RobotFrameworkPythonRemoteServer/tree/master

@pekkaklarck
Copy link
Member Author

Great that you are interested to help with this. I looked at your repo, but for some reason it seems that you have modified all files and it's totally impossible to see the actual changes. Probably best if you fork the repository again and add you changes on top of it. I'd also recommend creating a separate topic branch for the work as it makes it easier to create pull request later.

@zeinababbasi
Copy link

zeinababbasi commented Sep 18, 2017 via email

zeinababbasi added a commit to zeinababbasi/PythonRemoteServer that referenced this issue Sep 18, 2017
Changes has been made to support serving a list of libraries:
robotframework#19
zeinababbasi added a commit to zeinababbasi/PythonRemoteServer that referenced this issue Sep 18, 2017
Changes has been made to support serving a list of libraries:
robotframework#19
@livelace
Copy link

@pekkaklarck It seems that @zeinababbasi patch works. I have tested it with my libraries and it works.
When do you plan to merge this patch ?

@pekkaklarck
Copy link
Member Author

Great to hear that the code works. I still don't see any pull-request and that makes reviewing and merging changes hard. Are you @zeinababbasi interested to create a PR? If not, are you @livelace?

@wagnerd
Copy link

wagnerd commented Jul 15, 2018

Hi,
is there somethin missing for the PR to finish?
Thanks.

@pekkaklarck
Copy link
Member Author

It seems I have missed PR #47 that implements this. Unfortunately all my development time is currently spent with Robot Framework core and I don't really have time for this project until RF 3.1 is released.

@loumaran
Copy link

Hi,
RF 3.1 is now released :-) Maybe there is a little time slot for this great feature?
Regards,
Mario

@s-galante
Copy link

Any chance we may be able to get this in still? We are finding a need for it as well and this would eliminate our need to have 10-12 of these running.

@pekkaklarck
Copy link
Member Author

I'm sure this is added at some point, but unfortunately my time is still spent with Robot Framework core and at the moment with trying to get RF 3.2 ready. I'd be ready to share maintainer responsibilities with someone else if there'd be interest.

Erich-McMillan pushed a commit to Erich-McMillan/PythonRemoteServer that referenced this issue Dec 14, 2022
Changes has been made to support serving a list of libraries:
robotframework#19
Erich-McMillan pushed a commit to Erich-McMillan/PythonRemoteServer that referenced this issue Dec 14, 2022
Changes has been made to support serving a list of libraries:
robotframework#19
@AntonKueltz
Copy link

One thing that seems to work (YMMV) is creating a new class that inherits all of your libraries classes, effectively wrapping them into a single class. I say YMMV because there's bound to be edge cases folks will run into around name collisions for methods and fields, but at a high level this approach seems to work and provide a quick hack to enable this functionality.

from lib_a import LibraryA
from lib_b import LibraryB

from robotremoteserver import RobotRemoteServer


class MergedLibraries(LibraryA, LibraryB):
    pass


RobotRemoteServer(MergedLibraries())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants