V4.7.1 - p25 clicking on UDP stream VS wav that is good

[toddmay222]

./recorder -v
Trunk-Recorder: 4.7.1
commit 648524d (master)
describe LTS-265-g648524d
Author: Anthony Kava github@tonykava.com
Date: 2024-01-19 17:35:03 -0500

    Fix minor typos in debug logging for opcode 0x28 (#905)

CONCERN/ISSUE:
Recently upgraded trunk-recorder and utilized stream via UDP to a PTT app.

Clicking is evident on the audio being sent over UDP, but NOT found within the WAV file or m4a files.

To re-create:

1 - Create standard P25 config.

2 - Establish a UDP stream output:
"plugins": [
{
"name":"simplestream",
"library":"libsimplestream.so",
"streams":[{
"TGID":0,
"address":"127.0.0.1",
"port":9123,
"sendJSON":true,
"sendTGID":true}]
}
],

3 - Alter or remove your digitalLevels (makes no difference. 1-16 or completely removed)

4 - Sniff the wire using wiresharck or TCPdump to capture the UDP packets being sent out of Trunk-Recorder to whatever local app is listening.

5 - Make sure audioArchive is true so you can also get the output to files.

Compare the two audio sources. The outcome should appear to be:
WAV = GOOD
m4a = GOOD
UDP Output = CLICKING IN AUDIO

ASSUMPTIONS
I would ASSUME that the output WAV audio is being filters, cleaned, or processed through some functions or routines that the UDP audio is not.

It would be really nice if the UDP streaming plugin worked without the clicks... Any tips or wisdom is welcomed. :)

[kylegibbons]

I am having a similar problem with analog audio over UDP. I am sending the bits directly to a file and them playing them back with this command ffplay -f s16le -ar 16000 -ac 1 -i .\test_with_clicks.pcm

I hear clicks/pops/hiss throughout the length of the file, I have attached it here so you can hear it.
test_with_clicks.zip

Like OP, the files produced by trunk-recorder do not have these issues.

I was able to filter the clicks and create a new file using this command ffmpeg -f s16le -ar 16000 -ac 1 -i .\test_with_clicks.pcm -af adeclick -f s16le -ar 16000 -ac 1 test_with_filter.pcm

Here is the file
test_with_filter.zip

I agree with OP that is would be really helpful if the UDP stream was taken after the filters you are using for the file output. Maybe as a config option in case someone wants the raw audio. If this is not feasible, could we know what filters and parameters you are using on the file output? I have looked around the repo, but haven't had any luck finding it yet.