Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HardwareAcceleratedActivityRenderTest and ShadowNativeHardwareRendererTest fails on Mac #9044

Closed
hoisie opened this issue May 3, 2024 · 3 comments

Comments

@hoisie
Copy link
Contributor

hoisie commented May 3, 2024

On Mac, when red is drawn, the result ends up being blue. This implies Skia may be using BGRA instead of RGBA as the pixmap format (or vice-versa?). I have a fix that involves using BufferedImage to swizzle the bytes, but that adds overhead, and I am trying a simpler fix at the hwui layer.

@hoisie
Copy link
Contributor Author

hoisie commented May 3, 2024

Note this issue probably first appeared after c0c8e98 was merged. That commit fixed the alpha transparency issues in HW rendering, but surfaced a new issue in Mac (and potentially Windows?).

@utzcoz
Copy link
Member

utzcoz commented May 3, 2024

IIRC, tests only failed on macOS, and passed on Windows. So I think it might not affect Windows implementation.

@hoisie
Copy link
Contributor Author

hoisie commented May 3, 2024

copybara-service bot pushed a commit that referenced this issue May 7, 2024
This fixes inflating widgets like ProgressBar when native graphics
is used in certain locales, and fixes HW rendering on Mac.

See:
https://android.googlesource.com/platform/frameworks/base/+log/refs/heads/and
roid12-hostruntime-dev
for relevant changes.

Fixes #8478
Fixes #9044

PiperOrigin-RevId: 631471023
copybara-service bot pushed a commit that referenced this issue May 7, 2024
This fixes inflating widgets like ProgressBar when native graphics
is used in certain locales, and fixes HW rendering on Mac.

See:
https://android.googlesource.com/platform/frameworks/base/+log/refs/heads/and
roid12-hostruntime-dev
for relevant changes.

Fixes #8478
Fixes #9044

PiperOrigin-RevId: 631471023
@hoisie hoisie closed this as completed in 123e31a May 17, 2024
hoisie added a commit that referenced this issue May 18, 2024
This fixes inflating widgets like ProgressBar when native graphics
is used in certain locales, and fixes HW rendering on Mac.

See:
https://android.googlesource.com/platform/frameworks/base/+log/refs/heads/and
roid12-hostruntime-dev
for relevant changes.

Fixes #8478
Fixes #9044

PiperOrigin-RevId: 631527808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants