Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xreg not carrying through in arfima #735

Open
rkillick opened this issue Sep 21, 2018 · 2 comments
Open

xreg not carrying through in arfima #735

rkillick opened this issue Sep 21, 2018 · 2 comments

Comments

@rkillick
Copy link

Motivation: I want to fit an arfima model with regressors.

In arfima.R you are allowed to enter additional parameters that are carried forward to auto.arima. This is carried forward to line 156 where auto.arima is used and the ... is present.

However, as the default setting is "mle" fit, when you enter an xreg argument, the final fit doesn't display the xreg and the final arima fit is not working on the residuals of the xreg fit, see line 166 of the file.

I think this just needs a check to see if xreg is specified in ... and if so, the residuals of the xreg fit are carried forward and the xreg parameter estimates from auto.arima are carried forward to the final fit object too.

If you are happy with my (outline) suggested change I can make it in the code for you and commit.

@robjhyndman
Copy link
Owner

A simpler solution might be to add an xreg argument to arfima with default NULL, then just pass that to both auto.arima() and Arima().

In any case, feel free to make a PR.

@Jeremy537
Copy link

I am facing the same problem right now. Has anyone published a solution in the meantime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants