Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal destroys CLS (Cumulative Layout Shift) based on where the user is on page when opened. #150

Open
jmplummer opened this issue Mar 3, 2021 · 1 comment
Open

Modal destroys CLS (Cumulative Layout Shift) based on where the user is on page when opened. #150

jmplummer opened this issue Mar 3, 2021 · 1 comment
Labels
question

Comments

@jmplummer
Copy link

Has anyone else noticed that tingle causes drastic changes in CLS if scrolled further down the page and it puts top: -8000px for example on the <body> tag?

Any idea how to fix this using this plugin?
@robinparisi
Copy link
Owner

robinparisi commented Mar 13, 2021 •
edited

Hi,

I am not sure that CLS applies here since this metric measures the stability of the layout, so the opposite of the principle of a modal.

Maybe I'm missing something, could you share more informations about your measure and use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinparisi @jmplummer