Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython implementation of HoppingWindow.ranges returns tuples with (int, float) #674

Closed
2 tasks done
forsberg opened this issue Oct 20, 2020 · 0 comments · May be fixed by #675
Closed
2 tasks done

Cython implementation of HoppingWindow.ranges returns tuples with (int, float) #674

forsberg opened this issue Oct 20, 2020 · 0 comments · May be fixed by #675

Comments

@forsberg
Copy link

Checklist

  • I have included information about relevant versions
  • I have verified that the issue persists when using the master branch of Faust.

Steps to reproduce

Using a faust[fast], values stored in a Table with HoppingWindow are not retrievable via the .value() function.

Inspecting the RocksDB tables via ldb, the keys (given that we store an integer as key) are on the form:

[621, [1603100040.0, 1603100099.9]]

However, when trying to retrieve the data, the key asked for is on the form:

[621, [1603100040, 1603100099.9]]

This only happens when faust has been cythonized. When running with NO_CYTHON=True, the problem disappears.

The root cause seems to be the Cython implementation of HoppingWindow.ranges returning a tuple (int, float) instead of (float, float).

Possibly related to #223, #510, but not sure about that.

Versions

  • Python version: 3.8.5
  • Faust version: master
  • Operating system: Linux
  • Kafka version: N/A
  • RocksDB version: 5.17.2-3 (Ubuntu package)
forsberg added a commit to forsberg/faust that referenced this issue Oct 20, 2020
forsberg added a commit to forsberg/faust that referenced this issue Oct 21, 2020
forsberg added a commit to forsberg/faust that referenced this issue Oct 21, 2020
forsberg added a commit to forsberg/faust that referenced this issue Oct 21, 2020
forsberg added a commit to forsberg/faust-streaming that referenced this issue Nov 16, 2020
forsberg added a commit to forsberg/faust-streaming that referenced this issue Nov 16, 2020
forsberg added a commit to forsberg/faust-streaming that referenced this issue Nov 16, 2020
forsberg added a commit to forsberg/faust-streaming that referenced this issue Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant