Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream.take() function returns events() instead of values #660

Open
itsmesrds opened this issue Sep 27, 2020 · 1 comment · May be fixed by #661
Open

stream.take() function returns events() instead of values #660

itsmesrds opened this issue Sep 27, 2020 · 1 comment · May be fixed by #661

Comments

@itsmesrds
Copy link

This is a feature request, currently stream.take() returns only values from kafka, users are not able to access keys and meta information.

Expected behavior

stream.take() should return events()

Actual behavior

stream.take() returns only values from kafka

Versions

Python version : 3.6.9
Faust version 1.10.4
Operating system: Linux
@itsmesrds itsmesrds linked a pull request Sep 27, 2020 that will close this issue
Open
@fr-ser
Copy link
Contributor

fr-ser commented Oct 11, 2020

Would it make sense to include the "fix" for manual acknowledgment in this PR as well?
#513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added take_events() function itsmesrds/faust
2 participants
@fr-ser @itsmesrds