Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data download missing data #14

Open
robertmartin8 opened this issue May 24, 2018 · 8 comments
Open

Data download missing data #14

robertmartin8 opened this issue May 24, 2018 · 8 comments

Comments

@robertmartin8
Copy link
Owner

Based on some feedback received and subsequent experiments, it seems that the data download is missing out a lot of tickers (and if it's missing out the SPY, there will be an error in parsing_keystats.py).

This project downloads price data for free from Yahoo Finance, via pandas-datareader (and fix-yahoo-finance). However, I've noticed lately that the data is becoming a lot more inconsistent, and sometimes just fails completely. This is because Yahoo seems to be dropping their support for this API.

The data on yahoo is still there, it's just a problem of accessing it. In the past I wrote a blog post about downloading data from the linked source, but 'deprecated it' once I realised that pandas-datareader with fix-yahoo-finance did the same thing but much better. My method still works, but it won't be trivial to integrate it with the project (and anyway it's a very clunky solution). I suppose that the easiest solution is to find another data source, so suggestions would be welcome.

As a temporary fix, I have added the csv files (containing all the data) to this repo.

@ictinc
Copy link

ictinc commented Jun 3, 2018

Hi Robert,
Maybe instead of using Yahoo finance use IEX trading instead?
https://iextrading.com/developer/docs/

http://pandas-datareader.readthedocs.io/en/latest/readers/iex.html

Cheers,
Ronald.

@robertmartin8
Copy link
Owner Author

@ictinc

Hi Ronald,

Thank you for the suggestion, it looks like a very clean API and it's great that there's a pandas-datareader interface – it also has adjusted closing prices which is one of my veto factors for considering a service. I'll definitely look into it, it should just be a matter of changing the pandas-datareader call.

Thanks again,

Robert

@ictinc
Copy link

ictinc commented Jun 12, 2018 via email

@jackmoody11
Copy link

jackmoody11 commented Jul 25, 2018

@robertmartin8 There is a package that already exists to help out with this. It also outputs the data in a pandas format. It's named iexfinance.

@alvarobartt
Copy link

Hi @robertmartin8, congratulations on your great work!

I was just checking your GitHub profile when I got to this issue, so I will suggest you to use investpy since it is a Python package I developed for retrieving financial data from Investing.com which is a consistent reliable source and I think investpy can provide you the data you need.

Any further query or doubt feel free to ask me! Good luck with your studies @ Cambridge!

@robertmartin8
Copy link
Owner Author

Hi @alvarobartt, thanks for the kind words.

Investpy looks very cool – I am currently not actively maintaining MachineLearningStocks anymore, but I think it's perfect for some of the personal projects I've been doing!

@alvarobartt
Copy link

alvarobartt commented Mar 24, 2020

Oh it's ok @robertmartin8! If you need help just let me know!

@robertmartin8
Copy link
Owner Author

I've just been recommended another data source called SimFin, which has a really nice python API. Worth taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants