Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is trailingToSuperview offset inverted? #66

Open
piotrczurak opened this issue Oct 8, 2018 · 4 comments
Open

Why is trailingToSuperview offset inverted? #66

piotrczurak opened this issue Oct 8, 2018 · 4 comments

Comments

@piotrczurak
Copy link

Why is offset value being manually inverted in trailingToSuperView and leadingToSuperview functions basing on effectiveUserInterfaceLayoutDirection? I believe trailing/leading constraints are made precisely so that developers don't have to handle layout direction manually.
@ggirotto
Copy link

up

@crayment
Copy link

I have run into this as well. In general I think there are issues relating to RTL support and inverting offsets. I may be in a position to PR some changes around this. Would this get support? Any history I should be aware of?

@Lutzifer
Copy link
Contributor

Lutzifer commented Feb 5, 2019

I think #31 is some of the history of this, but it has been a while.

@roberthein
Copy link
Owner

Would you have time @crayment to create a proposal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@crayment @Lutzifer @roberthein @ggirotto @piotrczurak