Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Results Pagination #2

Open
rlingineni opened this issue Sep 30, 2018 · 0 comments
Open

Add Results Pagination #2

rlingineni opened this issue Sep 30, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rlingineni
Copy link
Owner

rlingineni commented Sep 30, 2018 •
edited

Currently, you can only pass in a count argument, and the result set in the backend is truncated to that arbitrary value.

  1. In the code change the slice method to return the range of indices the user requests, depending on the page requested
  2. Search response should also be updated to include the total number of pages possible

More complex, but optimal:

  1. At the core, the lunr.js should be updated to only return a fixed Save indexes directly to Lambda Function #1 of results (e.g. 25, not all)
  2. Repeat above steps
@rlingineni rlingineni added the good first issue Good for newcomers label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlingineni