Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing issue in rts_smoother #265

Open
mjsobrep opened this issue Mar 11, 2022 · 0 comments
Open

indexing issue in rts_smoother #265

mjsobrep opened this issue Mar 11, 2022 · 0 comments

Comments

@mjsobrep
Copy link

It looks like there is an indexing issue on the Fs:

Pp[k] = dot(dot(Fs[k+1], P[k]), Fs[k+1].T) + Qs[k+1]

I'm not sure why there are the k+1 indeces. I would expect this to be the same as the calculation of P in the forward pass:
self.P = self._alpha_sq * dot(dot(F, self.P), F.T) + Q

Comparing to the standalone smoother:

pP[k] = dot(dot(Fs[k], P[k]), Fs[k].T) + Qs[k]

the k+1 terms are not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant