Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dcco: Continue until call (use step out) #4347

Closed
wants to merge 2 commits into from
Closed

Add dcco: Continue until call (use step out) #4347

wants to merge 2 commits into from

Conversation

gogo2464
Copy link
Contributor

@gogo2464 gogo2464 commented Mar 9, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

dcco command to run dcc with step over.

...

Test plan

...

Closing issues

closes #4335

...

@github-actions github-actions bot added the RzCore label Mar 9, 2024
@gogo2464
Copy link
Contributor Author

gogo2464 commented Mar 9, 2024

dcco command not triggered yet.

meson setup build --wipe
meson compile -C build

.\build\binrz\rizin\rizin.exe --
 -- give | and > a try piping and redirection
[0x00000000]> dcco
ERROR: Command 'dcco' does not exist.
ERROR: Displaying the help of command 'dcc'.

ERROR: Usage: dcc   # Continue until call (use step into)
[0x00000000]>

Did I really recompiled the project please?

@gogo2464
Copy link
Contributor Author

gogo2464 commented Mar 9, 2024

Idk why does the continuous-integration/appveyor/pr does not work.

@gogo2464
Copy link
Contributor Author

gogo2464 commented Mar 9, 2024

I am confused with this fail: https://ci.appveyor.com/project/rizinorg/rizin/builds/49365813/job/n54rma5vu2787wlu#L2871

XVilka
XVilka requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 librz/core/cmd_descs/cmd_descs.c:20558:46: error: code should be clang-formatted [-Wclang-format-violations]
        rz_warn_if_fail(cmd_debug_continue_call_cd);
                                                    ^

librz/core/cmd/cmd_debug.c Show resolved Hide resolved
@wargio
Copy link
Member

wargio commented Mar 9, 2024

@gogo2464 please pull the changes i did, rebuild and push the changes in the code generated by the python yaml module.

@gogo2464
Copy link
Contributor Author

gogo2464 commented Mar 9, 2024

@wargio

@wargio wargio changed the title dcco Add dcco: Continue until call (use step out) Mar 10, 2024
XVilka
XVilka requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML and C are out of sync:

Run ./librz/core/cmd_descs/cmd_descs_generate.py --output-dir /tmp ./librz/core/cmd_descs/*.yaml
7975c7975
< 	.summary = "Continue until call (use step out)",
---
> 	.summary = "Continue until call (use over into)",
20560c20560
< 	RzCmdDesc *cmd_debug_continue_call_over_cd = rz_cmd_desc_argv_new(core->rcmd, dc_cd, "dcco", rz_cmd_debug_continue_call_over_handler, &cmd_debug_continue_call_over_help);
---
>     RzCmdDesc *cmd_debug_continue_call_over_cd = rz_cmd_desc_argv_new(core->rcmd, dc_cd, "dcco", rz_cmd_debug_continue_call_over_handler, &cmd_debug_continue_call_over_help);
Error: Process completed with exit code 1.

@wargio
Copy link
Member

wargio commented Mar 11, 2024

@gogo2464 you must compile it before commit otherwise meson will not generate the updated C files.

@gogo2464
Copy link
Contributor Author

is it done?

@wargio
Copy link
Member

wargio commented Mar 11, 2024

@gogo2464 i don't know what you are doing with git but doesn't look like you are committing stuff correctly. avoid to squash manually and let us do the squash, just ninja -C build && git commit -a -m 'add regenerated files' && git push

@gogo2464
Copy link
Contributor Author

It is exactly what I did

@wargio
Copy link
Member

wargio commented Mar 11, 2024 •
edited

@gogo2464 you definitively did not.

I have applied your changes and built rizin. these are the changes that were generated by the python yaml script.

image

Be sure you have pyYAML installed on your system and do not manually edit librz/core/cmd_descs/cmd_descs.c

@gogo2464
Copy link
Contributor Author

All the files that I modified were modified manually :(

@wargio
Copy link
Member

wargio commented Mar 11, 2024 •
edited

All the files that I modified were modified manually :(

you must not modify cmd_descs.c and cmd_descs.h manually. those are generated.

@gogo2464
Copy link
Contributor Author

I see. what should I do?

@wargio
Copy link
Member

wargio commented Mar 11, 2024

I see. what should I do?

Let me create a PR based on yours.

@gogo2464
Copy link
Contributor Author

thanks!!!

@wargio wargio mentioned this pull request Mar 11, 2024
Merged
5 tasks
@wargio wargio closed this Mar 11, 2024
@gogo2464
Copy link
Contributor Author

Could you reopen please? I just would like to try something 2 minutes.

@wargio wargio reopened this Mar 12, 2024
@gogo2464
Copy link
Contributor Author

I pushed again

@wargio
Copy link
Member

wargio commented Mar 14, 2024

this won't work because you must edit the yaml files to add a command in rizin.
I'm closing this because the command has been added in another PR.

@wargio wargio closed this Mar 14, 2024
@gogo2464
Copy link
Contributor Author

feature finished?

@gogo2464 gogo2464 mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio left review comments

@XVilka XVilka XVilka requested changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code dcco
3 participants
@gogo2464 @wargio @XVilka