Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle release improvements #97

Open
eric-schneider opened this issue Feb 7, 2024 · 3 comments
Open

Bundle release improvements #97

eric-schneider opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
DevOps Anything related to project operations (e.g. CI/CD) enhancement New feature or request

Comments

@eric-schneider
Copy link
Contributor

Two things:

  1. [bug] It appears that when at least two PRs are merged in rapid succession, the workflow creates the correct number of tags, but sets them both on the same (most recent?) commit. This results in multiple releases with the same content. See prod-6 and prod-7: https://github.com/riptano/docs-ui/releases
  2. [enhancement] We probably shouldn't generate a new release for updates to preview-src/* and README.adoc.
@eric-schneider eric-schneider added bug Something isn't working enhancement New feature or request DevOps Anything related to project operations (e.g. CI/CD) labels Feb 7, 2024
@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

@eric-schneider @colegoldsmith thanks for the bug report!

I just pushed a couple commits that will:

  1. Prevent release jobs running concurrently. If multiple PRs are merged in quick succession, the second merge will wait for the first to complete before proceeding.
  2. Each release is now generated for the target commit (the one merged that triggered the release) rather than what is on main. This should prevent the releases having duplicate content.

As for item number 2 - we can prevent a release by adding [no-release] to the commit (see my most recent commits). This puts the control in the hands of the author for whether or not a build is triggered.

That said, I do agree it would be nice if the release was also skipped if the only changes were to README or preview-src. I'll leave this issue open to track that enhancement.

@mlr mlr removed the bug Something isn't working label Feb 7, 2024
@eric-schneider
Copy link
Contributor Author

As for item number 2 - we can prevent a release by adding [no-release] to the commit (see my most recent commits). This puts the control in the hands of the author for whether or not a build is triggered.

@mlr Argh I'm sorry. You told me about this feature and I totally forgot. Going forward I'll make sure to use [no-release] as necessary.

@mlr
Copy link
Contributor

mlr commented Feb 8, 2024

@eric-schneider it's my bad for not adding it to the README 😅 I will get that updated soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Anything related to project operations (e.g. CI/CD) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants