Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate asset file fingerprinting #130

Closed
eric-schneider opened this issue May 7, 2024 · 3 comments · Fixed by #137
Closed

Investigate asset file fingerprinting #130

eric-schneider opened this issue May 7, 2024 · 3 comments · Fixed by #137
Assignees
Labels
enhancement New feature or request P2

Comments

@eric-schneider
Copy link
Contributor

When we temporarily pulled the global nav after launching the unified site on new AWS infrastructure, some users experienced UI issues like the top part of the page being cut off:

Screen Shot 2024-05-07 at 11 13 23 AM

@mlr thinks this is likely the browser caching old styles, and that the usual way to mitigate this is asset file fingerprinting. However, we're not sure if that’s something Antora supports out of the box. We should investigate if asset file fingerprinting is a desirable and achievable solution to this problem, since we will be adding more rich UI experiences in the near future.

@mlr
Copy link
Contributor

mlr commented May 7, 2024

A cursory search didn’t turn up any existing support for this from Antora unless they name it something else. It would most likely require a custom plugin/extension.

@eric-schneider
Copy link
Contributor Author

@mlr Do expect this to be an extension for the UI or Antora itself? Or both?

@mlr
Copy link
Contributor

mlr commented May 7, 2024

@eric-schneider not sure, it may not be doable without modifying Antora internals. Hard to say for sure without further exploration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants