Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image lightbox enhancements and fixes #120

Open
eric-schneider opened this issue Apr 19, 2024 · 0 comments
Open

Image lightbox enhancements and fixes #120

eric-schneider opened this issue Apr 19, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request P1

Comments

@eric-schneider
Copy link
Contributor

eric-schneider commented Apr 19, 2024

NOTE: This issue should probably be worked on in conjunction with #83.

We need to make some enhancements to the image lightbox (#68):

  1. The lightbox doesn't currently support images that use the svg:: macro. This is problematic because we use this macro to support embedded SVGs that honor our CSS styles for light and dark mode (example).

  2. We should probably add a background to the lightbox that's the same size as the image. Currently, images with transparent backgrounds look messy when overlaid on top of page content (example).
    image

  3. We need to be able to selectively turn off the lightbox for certain images (both block and inline images). We could probably handle this with a role similar to the remove-ext-icon role that we use for selectively disabling the external link icon.
    Currently, the lightbox is enabled for the badge icons on the Connection methods comparison page, which is a little silly:
    image
    But more importantly, when we enable the lightbox for the svg:: macro, we'll need to be able to turn off the lightbox for the graphics on the landing page:
    image

@eric-schneider eric-schneider added bug Something isn't working enhancement New feature or request P1 labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request P1
Projects
None yet
Development

No branches or pull requests

1 participant