Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global override of Math.random #27

Open
rileyjshaw opened this issue Oct 26, 2015 · 1 comment
Open

Remove global override of Math.random #27

rileyjshaw opened this issue Oct 26, 2015 · 1 comment
Labels

Comments

@rileyjshaw
Copy link
Owner

Early on, I decided to use seedrandom's { global: true } option. It was a silly decision in retrospect.

The big change here is that seedrandom should be internal to terra and not pollute Math.random().

Following this thread, seeded RNG should really be handled more granularly anyway. Initial thoughts:

  1. Each terrarium is given a unique ID
  2. This ID is used to seed the terrarium's RNG

That way, a terrarium recipe and ID are all you need to perfectly reproduce a simulation. It'll no-longer be bound to other uses of random() on the page.

Thanks @benswinden for the heads up! 👍

@iangilman
Copy link

Yes please! I just spent an hour trying to figure out why Math.random() always had the same values on my page...

I'm loving the library otherwise, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants