Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange File Names Under Windows #11

Open
jmkao opened this issue May 9, 2016 · 1 comment
Open

Strange File Names Under Windows #11

jmkao opened this issue May 9, 2016 · 1 comment

Comments

@jmkao
Copy link

jmkao commented May 9, 2016

When the githubRelease task is used under Windows, the assets are uploaded with names that include their full path, but with \ replaced with ., for instance:

https://github.com/WesGilster/Creation-Workshop-Host/releases

Where the release file is named "C.Users.wgilster.git.Creation-Workshop-Host.host.cwh-DEV001.zip"

When run under Linux, the file name contains only the basename, like:

https://github.com/jmkao/Creation-Workshop-Host/releases

I think, but I'm not sure since I've only looked at this a little, that this might be because of the logic in https://github.com/riiid/gradle-github-plugin/blob/master/src/main/groovy/co/riiid/gradle/ReleaseTask.groovy on line 73:

def name = asset.split('/')[-1]

I think that since you have a File object from the previous line, you can use file.getName() to do the same thing in a platform independent way, but I'm not sure how the name object is used downstream, so I'm not sure if this would have any negative consequences.

@milosmns
Copy link

👍 I was about to report the exact same thing with the exact same split line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants