Source Inspection reveals too many generated white spaces.

[nitanmarcel]

Hi! After I published my site a friend of mine did a source inspection which revealed that the generated code has too many sources included.

Browning on the internet I've found a fix by replacing all {{% with {{%-.

Yet even after this, there's a big blank space at the end of the main page source code I have no idea how to fix.

Any ideas?

Source before my changes:

[nitanmarcel]

Completely fixed all the problems with the generated code thanks to https://github.com/apsislabs/jekyll-tidy

[riggraz]

Hi nitanmarcel!

Actually I believe that version 0.4.0 fixes this whitespace problem. See this commit. In fact, I don't encounter this problem on my blog which is updated to version 0.4.0 of no-style-please.

Anyway I'm glad that you found a workaround in the meanwhile. If you decide to update the theme, let me know if it fixes the problem!

[nitanmarcel]

Oh. I was making a PR. Those places are not the only places where the tags need to be replaced. I'll finish the PR and you could look at it ^^

[nitanmarcel]

@riggraz done the PR, I would be happy if you could check it ^^

[riggraz]

Actually I was looking at my blog through "Inspect element" and didn't notice the whitespaces there. With "View page source", however, they're visible.

I'll take a look at your PR in the next days. Anyway, thanks a lot for taking the time to contribute!

[riggraz]

PR #15, which removes some whitespaces, was merged today. However there are still some whitespaces here and there, so I'll keep this issue open if someone wants to work on it.

I remember that it'd be cool to remove whitespaces without using any third party dependency like jekyll-tidy, since this theme strives to remain as lightweight as possible!

[nitanmarcel]

@riggraz just had an idea. This would work only with gh-pages tho, and if user want to host this locally will have to do these manually.

There are libraries with command lines interfaces which can minify the generated html. What about creating a GitHub workflow to do such thing?

I've also found something on stackoverflow but I'm not so sure if it will break something or not.

https://stackoverflow.com/a/25803493/12420972

[riggraz]

There are libraries with command lines interfaces which can minify the generated html. What about creating a GitHub workflow to do such thing?

To be honest I think it'd be a little overkill, but thanks anyway for the suggestion.

I've also found something on stackoverflow but I'm not so sure if it will break something or not.

This is pretty interesting and may fix the problem without adding dependencies. I'm not sure if it works so it should be tested. If you want to work on it let me know