Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with UIPageviewController with moveTo #318

Open
3 tasks done
IronMaltes opened this issue Sep 16, 2021 · 4 comments
Open
3 tasks done

Problem with UIPageviewController with moveTo #318

IronMaltes opened this issue Sep 16, 2021 · 4 comments
Labels

Comments

@IronMaltes
Copy link

New Issue Checklist

Issue Description

Hi Richard,

I have a problem once I changed to iOS15, I waited till the iOS15 RC to write this issue.
The problem is that changing days using 'moveTo' or using the header, at the end everything gets messy, half pages, not doing apparently the layout or some other things you can see on the video attached.

I tried removing all my code that modifies the creation of the Event with no success.
I've seen that inside the func move in TimelinePagerView that (pagingViewController.setViewControllers) you implemented some kind of workaround, but seems not to work right now. I did also some research in stackoverflow with little success.

Do you have any advice on this?

Thanks a lot.
Alex.

RPReplay_Final1631788416.mov
@IronMaltes
Copy link
Author

After some more research, I found a workaround modifying the calendar kit function move - pagingViewController.setViewControllers with animate + false (with no hidden reload), just for the moveTo.

I suspect is related to the time my loadEvents delegate took (now I pre cache the info just for the move to) and also to several animation taking place at the same time. That I think is the main root cause.

What’s your thoughts on that, make sense?

@richardtop richardtop added the bug label Sep 17, 2021
@richardtop
Copy link
Owner

richardtop commented Sep 17, 2021

Hi Alex, thanks for the bug report.
Could you please confirm:

  1. whether this is reproducible in the demo project in the CalendarKit
  2. In the CalendarApp https://github.com/richardtop/CalendarApp
  3. please, share the code you're using here.

Once I get this info, I'll be able to assist you.

@IronMaltes
Copy link
Author

My problem is solved with the workaround I described above. You can close this issue if you want. Nevertheless if you want more info on what a I’ve done I can extend the explanation.

Is the same problem I had in other parts of my app when using page view control. And also looks the same as many other problems I saw in stack overflow and here, the animations of pageview and other collide (or some processes inside the layout…) or don’t have time to execute properly, but just for the function (setViewController or for instance in calendarkit, moveTo) not for the swipe left or right.

Thanks for your nice work with this pod 😉

@richardtop
Copy link
Owner

Yeah, please share the workaround and the places where you had to put it. Also, links to the SO with the same questions would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants