Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calling DayViewState.move(to:) calendar sometimes skips a week #120

Open
eoy4 opened this issue Dec 13, 2017 · 11 comments
Open

When calling DayViewState.move(to:) calendar sometimes skips a week #120

eoy4 opened this issue Dec 13, 2017 · 11 comments
Labels

Comments

@eoy4
Copy link

eoy4 commented Dec 13, 2017

What the title says. It sometimes works as expected, others it would scroll briefly to the desired date, and then fast forward one week. I'm just calling dayView.state?.move(to: someDate).

@richardtop richardtop added the bug label Dec 25, 2017
@Ihernandezpi
Copy link

The same issue :(

@sinkync
Copy link

sinkync commented Jan 10, 2018

the same issue

@richardtop
Copy link
Owner

@hevatix, @sinkync I am aware of this issue and will fix it as soon as possible.
If you'd like to debug and fix it manually, you may look for false positive Control Loops (by setting breakpoints on the interface methods between multiple modules).

@Ihernandezpi
Copy link

Ihernandezpi commented Jan 10, 2018

@richardtop I had already run debug and I think the bug is when TimeLinePagerView Scrollview is trigger when change the date with "moveTo!" I´m not sure how it works but I just comment the line 147 at TimelinPagerView and it works "moveTo" but the pager scroll to change the date doesn't work anymore

@richardtop
Copy link
Owner

@hevatix Thanks for reporting it. Seems, that you've broken one of the control loops.
The idea, that all the state changes should go through DayViewState and there should be no loops - the state should act as a "dispatcher" and pass new state information to the other modules.

richardtop added a commit that referenced this issue Apr 4, 2018
@richardtop
Copy link
Owner

Should be fixed in #145

@zungx
Copy link

zungx commented May 20, 2018

Still same issues

@eoy4
Copy link
Author

eoy4 commented May 20, 2018

Same here :( Can you reopen this one?

@richardtop richardtop reopened this May 29, 2018
@eoy4
Copy link
Author

eoy4 commented Aug 20, 2018

@richardtop I would love to help fix this issue, now that I am more proficient with Swift. Can you point me in the direction of what I have to look for?

@richardtop
Copy link
Owner

@eoy4
Copy link
Author

eoy4 commented Sep 14, 2018

@richardtop this stopped happening to me in latest release. YAY! If others confirm, I think this is fixed.

@richardtop richardtop reopened this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants