Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type method on function values #922

Open
zolamk opened this issue May 31, 2023 · 0 comments
Open

fix type method on function values #922

zolamk opened this issue May 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@zolamk
Copy link
Contributor

zolamk commented May 31, 2023

Describe the bug

Currently for the FunctionValue type the Type() method only has a placeholder implementation which is fine for now since it's not in use, we need to have a correct implementation that returns the correct function signature.

reviewpad/lang/value.go

Lines 221 to 225 in c5a4d1a

// TODO: Implement a more reliable function type
// that returns the actual parameters and return type
func (fVal *FunctionValue) Type() Type {
return BuildFunctionType([]Type{}, BuildBoolType())
}

@zolamk zolamk added the bug Something isn't working label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant