Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated reviewers methods #765

Open
shay2025 opened this issue Mar 8, 2023 · 0 comments
Open

Duplicated reviewers methods #765

shay2025 opened this issue Mar 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@shay2025
Copy link
Contributor

shay2025 commented Mar 8, 2023

Description

In the pull request target methods, we have 2 methods GetReviewers and GetRequestedReviewers whose purpose seems to be the same which is get the requested reviewers. Maybe we could just have one single method called GetRequestedReviewers that returns the requested reviewers and another method called GetReviewers which returns the reviewers of the pull request.

Notice that reviewers and requested reviewers are two different concepts. A reviewer is a user who submitted a review while a requested reviewer is a user who was asked to review a pull request but it still hasn't done so.
@shay2025 shay2025 added the enhancement New feature or request label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shay2025