Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command assign-reviewers should wait for checks by default #474

Open
ferreiratiago opened this issue Nov 25, 2022 · 0 comments
Open

Command assign-reviewers should wait for checks by default #474

ferreiratiago opened this issue Nov 25, 2022 · 0 comments
Labels
commands enhancement New feature or request

Comments

@ferreiratiago
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the reviewpad command assign-reviewers does a direct assignment of the reviewers. It would be great if we could add intelligence to the commands such as waiting for the pull request checks to be all green.

Describe the solution you'd like
The reviewpad command assign-reviewers should, by default, wait for all checks to be green before executing the assignment.

If any of the checks fail, reviewpad should provide feedback as a comment in the pull request.

When running the command, reviewpad should provide feedback while waiting for the checks to fininsh.

Here's an idea of the timeline of the events:

  1. User comments /reviewpad assign-reviewers
  2. Pull request has checks?
    • Yes
      • Any check failed - comment that the command will not be executed.
      • Any check in progress - comment the command will run once all checks passed.
      • All checks passed - run the command and comment the output of the execution.
    • No - Then reviewpad executes the command and comments the executing output on the pull request.

Force (--force / -f)

The user should be able to force the execution of the command, regardless of the checks. For that, we need to add the flag --force or -f that will run the command ignoring the status of the checks.

@ferreiratiago ferreiratiago added enhancement New feature or request commands labels Nov 25, 2022
@reviewpad-bot reviewpad-bot added the stale Stale issue/pull request label Dec 3, 2022
@shay2025 shay2025 removed the stale Stale issue/pull request label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands enhancement New feature or request
Projects
No open projects
Status: 💬 Triage
Development

No branches or pull requests

3 participants