Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify aladino and engine mocks #460

Open
ferreiratiago opened this issue Nov 24, 2022 · 0 comments
Open

Clarify aladino and engine mocks #460

ferreiratiago opened this issue Nov 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ferreiratiago
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, both aladino and engine provide mocks for pull request details.

If you open engine/mocks.go you will see that it has the function GetDefaultMockPullRequestDetails which is also provided on lang/aladino/mocks.go.

This can be a bit confusing as to what mock function should be called.

Describe the solution you'd like
In this issue we would like to address:

  • Investigate the need for both function
    • If both are required then name them differently and document the explanation for both to exist.
  • Investigate if there are some other functions that may bring confusion or aren't really necessary.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Please provide the output of the investigation in the issue discussion.

@ferreiratiago ferreiratiago added the enhancement New feature or request label Nov 24, 2022
@reviewpad-bot reviewpad-bot added the stale Stale issue/pull request label Dec 2, 2022
@shay2025 shay2025 removed the stale Stale issue/pull request label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: 💬 Triage
Development

No branches or pull requests

3 participants