{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":285304,"defaultBranch":"master","name":"reviewboard","ownerLogin":"reviewboard","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-08-22T21:39:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/118199?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1704306130.0","currentOid":""},"activityList":{"items":[{"before":"1219b5b5c6128402815c11ba27bb8b21d0db1017","after":"dc96ca4c5138eda9fb9e38ada940b618b3314005","ref":"refs/heads/release-7.x","pushedAt":"2024-05-05T01:33:28.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix the color of field section labels for diffs in dark mode.\n\nThe Diff Revision, Commits, and Files section headers in the diff viewer\npage had a dark grey background, which conflicted with the background\nand didn't match the styling of the rest of the page.\n\nWe unfortunately don't have any standard classes for these that we can\ndepend on. This should be addressed, but not for this release, as it'd\nintroduce too many structural changes that aren't worth fixing up right\nnow.\n\nIn the meantime, we're now referencing the field label styling via CSS\nvariables. We're also using the proper font size for section labels,\nwhich is smaller than we had before, but more consistent with the rest\nof the page.\n\nTesting Done:\nTested the review request and diff viewer pages in light and dark mode,\nand compared the styling to the other section headers.\n\nReviewed at https://reviews.reviewboard.org/r/13823/","shortMessageHtmlLink":"Fix the color of field section labels for diffs in dark mode."}},{"before":"261ff4a341b1fdd19a4f6193eca636c8c27b614d","after":"1219b5b5c6128402815c11ba27bb8b21d0db1017","ref":"refs/heads/release-7.x","pushedAt":"2024-05-04T05:13:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Update package.lock for beanbag-frontend-buildkit bump.\n\nTrivial update to package.lock.","shortMessageHtmlLink":"Update package.lock for beanbag-frontend-buildkit bump."}},{"before":"5f0d50c0340e43c920b1a23375ec2b7b418193c4","after":"261ff4a341b1fdd19a4f6193eca636c8c27b614d","ref":"refs/heads/release-7.x","pushedAt":"2024-05-04T04:31:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up a bunch of lint issues.\n\nThis change fixes up a bunch of mostly-harmless linter errors. The vast\nmajority of these are unused imports or variable assignments that are\nnever used.\n\nTesting Done:\nRan unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13805/","shortMessageHtmlLink":"Fix up a bunch of lint issues."}},{"before":"1a38fe02b6c0f6e7d6b6b55837ca4035a8c72c2a","after":"5f0d50c0340e43c920b1a23375ec2b7b418193c4","ref":"refs/heads/release-7.x","pushedAt":"2024-05-03T16:26:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up a bunch of typos and misspellings.\n\nThis change fixes up the vast majority of typos and misspellings in our\ncodebase. The one non-false-positive hit that I've chosen not to change\nis the \"collapsable\" key in the diff chunks, since that data is stored\nin cache and might cause bad behavior after an upgrade.\n\nTesting Done:\n- Ran python tests.\n- Ran js tests.\n\nReviewed at https://reviews.reviewboard.org/r/13806/","shortMessageHtmlLink":"Fix up a bunch of typos and misspellings."}},{"before":"41053f2347f44fd6fcb1cdc0c831d79c61b7d4d9","after":"1a38fe02b6c0f6e7d6b6b55837ca4035a8c72c2a","ref":"refs/heads/release-7.x","pushedAt":"2024-04-30T14:27:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Increase the max length for WebHookTarget's URL field.\n\nThis increases the max length for WebHookTarget's URL field from\n200 characters to 512.\n\nTesting Done:\n- Ran the evolution, with existing webhook targets in my DB.\n- Ran unit tests.\n- Tested adding/updating/deleting webhook targets.\n\nReviewed at https://reviews.reviewboard.org/r/13793/","shortMessageHtmlLink":"Increase the max length for WebHookTarget's URL field."}},{"before":"07df4692e451b698a686e687abb804b6f570853f","after":"41053f2347f44fd6fcb1cdc0c831d79c61b7d4d9","ref":"refs/heads/release-7.x","pushedAt":"2024-04-29T21:41:02.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode for review entries, status updates, and change descriptions.\n\nAll the review-related content on the review request page now supports\nboth light and dark modes. This includes reviews, change descriptions,\nstatus updates, and replies.\n\nThere are some small color changes here and there, particularly to\nreplies and to status updates, to better align with the palettes and\nprovide better contrast. Change descriptions use diff theme colors for\nall insert/delete indications.\n\nThe \"Reply\" and \"Comment\" links have been replaced with buttons, better\nhelping indicate that they trigger an action when clicked, rather than\ntaking the user to another page.\n\nTesting Done:\nTested on a variety of reviews, replies, changes, and status updates I\nhad locally.\n\nThis will of course need more real-world testing.\n\nReviewed at https://reviews.reviewboard.org/r/13801/","shortMessageHtmlLink":"Add dark mode for review entries, status updates, and change descript…"}},{"before":"b9f33cce03fbdbb51fd6f25fbb57075a7a68a912","after":"07df4692e451b698a686e687abb804b6f570853f","ref":"refs/heads/release-7.x","pushedAt":"2024-04-25T20:38:11.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix a couple broken js-tests.\n\nThe new CommentIssueBarView implementation caused some test breakages in\nthe js-tests suite. This change fixes those up.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13792/","shortMessageHtmlLink":"Fix a couple broken js-tests."}},{"before":"98a41812289d1d5f60ea32694c7c4b681bdc46c7","after":"b9f33cce03fbdbb51fd6f25fbb57075a7a68a912","ref":"refs/heads/release-7.x","pushedAt":"2024-04-25T08:45:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode to the diff viewer.\n\nThis change updates the diff viewer to support dark mode. We use the\nfollowing palette:\n\n* Diff headers: Cool grey\n* Equals lines: Black background, dark grey line number background\n* Insert lines: Dark leafy green background, less-dark line number\n  background\n* Replace lines: Dark tan background, light-tan line number background\n* Delete lines: Dark muted red, less-red line number background.\n* In-line changes: goldenrod background.\n\nThere are some structural changes to how we supply colors to the diff\nviewer. Instead of several complex rules used to override colors and\nprioritize borders, we now use CSS variables to define all our colors\nfor a `<tbody>`, letting us apply them in a standard way. Borders are\nnow alpha-transparent colors, helping to visually merge borders\ntogether.\n\nThe colors are defined by the syntax highlighting theme. This will later\nallow other diff themes to choose colors more appropriate for their\nstyles. We provide a default set. These colors are chosen based on\nwhat both looks good and provides suitable contrast for all chunk types,\nand is not tied to our standard color palette.\n\nThere's also a fix included here for showing new and deleted files\ncorrectly in the mobile diff viewer.\n\nAt this time, binary file review does not have a dark mode appearance.\nThat will need to be addressed separately.\n\nTesting Done:\nTested a variety of changes in light and dark mode, mobile and desktop.\n\nTested highlighted lines and in-page diff navigation.\n\nThere will no doubt be further changes needed as we test more.\n\nReviewed at https://reviews.reviewboard.org/r/13779/","shortMessageHtmlLink":"Add dark mode to the diff viewer."}},{"before":"605fd4227219c6cd7d2bddd58ca46e3c19d2005d","after":"98a41812289d1d5f60ea32694c7c4b681bdc46c7","ref":"refs/heads/release-7.x","pushedAt":"2024-04-25T05:04:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Add DiffSet to clean-orphaned-data.\n\nApparently DiffSet is another type of object that we can leave orphaned\nin certain situations. This change adds it to the clean-orphaned-data\ncommand.\n\nWhile I was here I cleaned things up a bit to remove unused parameters\nand plumb through a missing argument that was causing us to count things\ntwice.\n\nTesting Done:\nCreated a bunch of orphaned DiffSet objects and ran this to delete them.\n\nReviewed at https://reviews.reviewboard.org/r/13787/","shortMessageHtmlLink":"Add DiffSet to clean-orphaned-data."}},{"before":"ee5e2ebc4c602845bed66d7bf5c8172dda978eca","after":"605fd4227219c6cd7d2bddd58ca46e3c19d2005d","ref":"refs/heads/release-7.x","pushedAt":"2024-04-24T21:59:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Tweak styles on forms in boxes to prevent some ugliness.\n\nThe OAuth application edit form uses our old `{% box %}` stuff, and a\nconflict between the styling for boxes and the styling for `.rb-c-form`\nwas causing the background image in the box to shift up by the margin\nadded to the buttons. This change overrides the styling for the actions\nto use padding instead of margin.\n\nTesting Done:\nLooked at the application edit form and saw that it wasn't ugly.","shortMessageHtmlLink":"Tweak styles on forms in boxes to prevent some ugliness."}},{"before":"50de7b879190c6847c8a72b915b48f574c5ed39e","after":"ee5e2ebc4c602845bed66d7bf5c8172dda978eca","ref":"refs/heads/release-7.x","pushedAt":"2024-04-24T15:54:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up one more user-visible \"submitted\" string.\n\nThis fixes one last user-visible instance of the \"submitted\" label,\ninside the last update popup.\n\nTesting Done:\nClosed a review request from one tab and waiting with it open in\nanother. Saw that the updates pop-up said \"completed by david\" instead\nof \"submitted by david\".\n\nReviewed at https://reviews.reviewboard.org/r/13778/","shortMessageHtmlLink":"Fix up one more user-visible \"submitted\" string."}},{"before":"e2b13e621a211eb24e569481f399121f87582633","after":"50de7b879190c6847c8a72b915b48f574c5ed39e","ref":"refs/heads/release-7.x","pushedAt":"2024-04-24T05:21:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix draft comments on unpublished diffs.\n\nWe weren't including the draft's diffset in the list of all diffsets,\nwhich could cause a KeyError when attempting to compute the comments\nhint data when there was a comment on an unpublished draft. This change\nfixes that so we include the diffset and all its filediffs in the list\nof all diffsets and filediffs.\n\nTesting Done:\nReproduced the bug with comments on draft diffs and verified that it no\nlonger occurred.\n\nReviewed at https://reviews.reviewboard.org/r/13777/","shortMessageHtmlLink":"Fix draft comments on unpublished diffs."}},{"before":"574adcd4804aa5c59998ecec8561b2a7d0d27dbb","after":"e2b13e621a211eb24e569481f399121f87582633","ref":"refs/heads/release-7.x","pushedAt":"2024-04-23T22:53:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Add a management command to clean up orphaned data.\n\nThis change adds a new management command that will clean up various\npieces of data in the database and filesystem that could have been left\nbehind if administrators used the \"Delete Permanently\" action on a\nreview request or deleted review requests via the admin UI.\n\nIt will query each of the affected items to get a total count, and then\nperform the actual deletion in batches. This allows us to show nice\nprogress bars, as well as make the command interruptible.\n\nTesting Done:\n- Populated my database with a bunch of data including screenshots,\n  file attachments, diffs, and change descriptions. Temporarily disabled\n  our new signal handler and deleted the review requests.\n\n  Ran with --show-counts-only and saw the expected counts for each type\n  of object.\n\n  Ran normally and watched it delete all the objects.\n\n  Ran again with --show-counts-only and saw that it no longer reported\n  any orphaned data.\n- Set the batch size low and verified that the progress bars worked\n  correctly.\n- Built and looked at the docs.\n\nReviewed at https://reviews.reviewboard.org/r/13740/","shortMessageHtmlLink":"Add a management command to clean up orphaned data."}},{"before":"993d3505afae94d6434da2bd7206e87821042da5","after":"574adcd4804aa5c59998ecec8561b2a7d0d27dbb","ref":"refs/heads/release-7.x","pushedAt":"2024-04-23T20:47:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode and interaction improvements for the comment dialog.\n\nThe comment dialog now supports light and dark modes, covering both the\nstandard comment editing UI and the Other Comments sidebar. A couple of\nimprovements to the UI have been made in the process, namely proper\ncentering of the issue/Markdown-related checkboxes and work on the issue\nbar to ensure a more compact, vertical view.\n\nA fix was also made to help avoid losing the comment dialog. It used to\nbe that using the scroll wheel on the text area or another part of the\ncomment dialog could result in scrolling the page far away from the\ncomment dialog. Now these events are caught, preventing that from\nhappening.\n\nThere's also one small color tweak. The dark mode variant of\n``-rb-p-draft-bg`` is now just a bit lighter, helping the dialog stand\nout from the rest of the UI. This also brightens the Unified Draft\nBanner, which also helps that stand out as well. This helps elevate\nthese interactive elements above the content.\n\nTesting Done:\nTested on light and dark modes.\n\nReviewed at https://reviews.reviewboard.org/r/13767/","shortMessageHtmlLink":"Add dark mode and interaction improvements for the comment dialog."}},{"before":"c74afa8af79b671cf3053ac38c31090ef71113f2","after":"993d3505afae94d6434da2bd7206e87821042da5","ref":"refs/heads/release-7.x","pushedAt":"2024-04-23T20:45:56.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update the diff collapse button for dark mode.\n\nIn light mode, the diff collapse button retains the styling we had\nbefore. However, in dark mode, it takes on a Primary Button appearance.\nThis helps it stand out better against the dark background.\n\nSome effort was put into just using a button styling across the board,\nbut ultimately I decided not to affect the light mode appearance too\nmuch at this stage.\n\nTesting Done:\nTested on light and dark mode.\n\nReviewed at https://reviews.reviewboard.org/r/13763/","shortMessageHtmlLink":"Update the diff collapse button for dark mode."}},{"before":"89a049fe21fb5d245273600e75173ef3830536ff","after":"c74afa8af79b671cf3053ac38c31090ef71113f2","ref":"refs/heads/release-7.x","pushedAt":"2024-04-23T03:27:11.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix commits list with draft diffs.\n\nWhen viewing a draft diff, the commits list in the diff viewer would not\nrender properly. This was happening because the query for all commits\nwas not including the draft diffset. This change fixes that up and adds\nunit tests for the two cases of published diff and draft diff.\n\nTesting Done:\n- Verified that I could view the commits list for a draft diff.\n- Ran unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13770/","shortMessageHtmlLink":"Fix commits list with draft diffs."}},{"before":"27e6a9109d465849353600103f820ffca8d27c8d","after":"89a049fe21fb5d245273600e75173ef3830536ff","ref":"refs/heads/release-7.x","pushedAt":"2024-04-21T04:02:05.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix menu styling in the top bar.\n\nWith recent changes, the menu styling in the top bar became the default\nInk menu color. We now customize the styling here, and also set the\nmenus to align to the right edge of the dropdown handles.\n\nText color for the headers was also incorrect for the color being used\nwhen on light mode. We now set that to the intended value as well.\n\nTesting Done:\nTested the top bar and its menus in light and dark modes. They now look\nas they did before.\n\nReviewed at https://reviews.reviewboard.org/r/13757/","shortMessageHtmlLink":"Fix menu styling in the top bar."}},{"before":"5ffe8030fa5b584651f4bd9c13ba4b18a748b92d","after":"27e6a9109d465849353600103f820ffca8d27c8d","ref":"refs/heads/release-7.x","pushedAt":"2024-04-21T04:01:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Redesign the trophy display and add a trophies component.\n\nThis introduces `.rb-c-trophies`, a formal component for showing\ntrophies. This replaces the old `.box.trophies`, and is quite different.\nIt's the first big visual update for trophies since 1.0.\n\nThe new styling doesn't enclose trophies in a box, and isn't\nleft-aligned. Instead, these are now shown outside of a box, centered on\nthe page, with a trophy on either side of the text. The trophies are\nslightly slanted away from the text.\n\nThe text is now a golden-ish color (which is a bit brighter on dark\nmode, and a darker gold on light mode).\n\nRemoving the banner and adding the slanted trophies gives this a little\nbit more personality. In the future, new trophy images could really help\nmake this stand out.\n\nTesting Done:\nTested on light and dark modes on mobile and desktop, with both sparkly\nand fish trophies.\n\nReviewed at https://reviews.reviewboard.org/r/13746/","shortMessageHtmlLink":"Redesign the trophy display and add a trophies component."}},{"before":"f20593754e3d8707da1ef1812e3a7a7fa70421ac","after":"5ffe8030fa5b584651f4bd9c13ba4b18a748b92d","ref":"refs/heads/release-7.x","pushedAt":"2024-04-21T03:59:28.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Rewrite the diff complexity icon to output SVGs.\n\nThe diff complexity icon, shown in the diff viewer's file index and in\nthe Review Request Updated boxes, has historically used jquery-flot to\ndo the rendering. This rendered to a canvas, had a white stroke area,\nand did not scale well. It was also not accessible, and not easy to\nstyle. It was a non-starter for dark mode.\n\nThis change rewrites this entirely to output SVGs. We do this by hand,\nas bringing in a library like D3 at this stage would take some care as\nto not impact Power Pack.\n\nThe code generates the segments, normalizes percentages to enforce\nminimums, and then generates SVG path data for each of the segment arcs.\nIt calculates an outer radius and an inner radius, as we did with flot,\nand give us a graph that correctly shows an overview of the changes made\nto the file.\n\nIt also comes with a new tooltip and accessibility information\ndescribing the number of changes to a file, and what types of changes\nwere made. All the relevant numbers are included.\n\nStyling is done with CSS, giving us full control over light and dark\nmode styling.\n\nTesting Done:\nTested a wide range of boundary conditions for the icon in Storybook,\nand compared to the original implementation in each (using a flag I\nhad in development for triggering the original rendering logic).\n\nCompared against the old rendering for a number of test diffs. Aside\nfrom very minor differences (new color palette, very slight rendering\nchanges), the appearance was the same.\n\nTested in light and dark modes.\n\nChecked the accessibility tree.\n\nReviewed at https://reviews.reviewboard.org/r/13741/","shortMessageHtmlLink":"Rewrite the diff complexity icon to output SVGs."}},{"before":"67b5f50784c709f5d4b8a8c514021982fc083ebe","after":"f20593754e3d8707da1ef1812e3a7a7fa70421ac","ref":"refs/heads/release-7.x","pushedAt":"2024-04-20T01:00:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Set ReviewRequest.diffset_history to NULL on delete.\n\nWhen a diffset history object is deleted, we don't actually want to\ncascade and delete the review request. This change fixes that to set the\nrelation to NULL instead.\n\nThis is in preparation for a change that fixes it so we properly delete\nthe diffset history when deleting the review request (the opposite of\nwhat the on_delete handler would previously do).\n\nTesting Done:\nRan the evolution.\n\nReviewed at https://reviews.reviewboard.org/r/13734/","shortMessageHtmlLink":"Set ReviewRequest.diffset_history to NULL on delete."}},{"before":"5e65325cf6dd371eee40bb19f7343785c27e5b26","after":"67b5f50784c709f5d4b8a8c514021982fc083ebe","ref":"refs/heads/release-7.x","pushedAt":"2024-04-19T22:38:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode support for the review request box.\n\nThis introduces the beginnings of dark mode for the review request box.\nIn dark mode, the box takes on a cool-grey, almost blue-ish tone,\ncontrasting with the background but remaining dark and keeping the focus\non the content.\n\nMost of the UI is converted over, but not all. The text boxes appear\nlight when in edit mode, and contrast quite a bit with the box, and the\nfile attachments and issue status area need new styling as well.\nHowever, this gets us most of the way there.\n\nThere are some structural changes. The actions area is now styled using\na flexbox, instead of carefully managing floats. This helps us style\nthings just a bit more correctly, and will hopefully avoid some of the\noff-by-one issues previously encountered on some platform/browser\ncombinations where the Reviews/Diff/Files tabs weren't fully connected\nto the box.\n\nThere's also a fix to the field validation warning display. This appears\nto have regressed at some point (likely Review Board 6 timeframe), where\nthe warning was populated with an attribute of the field verification\nerror, which didn't exist due to the error itself being a string. We'll\nwant to backport this later.\n\nFuture changes will introduce more styling to the contents of this box.\n\nTesting Done:\nTested this on Chrome and Firefox in light, dark, and system color\nschemes on both mobile and desktop views.\n\nTested field editing, validation, and action dropdowns to ensure the\nstyling was correct.\n\nReviewed at https://reviews.reviewboard.org/r/13729/","shortMessageHtmlLink":"Add dark mode support for the review request box."}},{"before":"59447b9cbc651bbeb405740cc6da6e73c4430eca","after":"d0e6a04f775c88445e0ce7479b7feeea1adf2a75","ref":"refs/heads/master","pushedAt":"2024-04-19T15:55:32.000Z","pushType":"push","commitsCount":47,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-7.x'","shortMessageHtmlLink":"Merge branch 'release-7.x'"}},{"before":"3eef886f2469a4e63a4ec9b9f196c7b31775777a","after":"5e65325cf6dd371eee40bb19f7343785c27e5b26","ref":"refs/heads/release-7.x","pushedAt":"2024-04-19T15:55:21.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-6.x' into release-7.x","shortMessageHtmlLink":"Merge branch 'release-6.x' into release-7.x"}},{"before":"d017db2e1c49be3a397615887a1f2fd67abcda84","after":"f680802a68f6f73172e782ff8a96958815c2f95e","ref":"refs/heads/release-6.x","pushedAt":"2024-04-19T15:54:03.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-5.0.x' into release-6.x","shortMessageHtmlLink":"Merge branch 'release-5.0.x' into release-6.x"}},{"before":"f58541ce610ec3f4760b677715b6f4b48ca42c7c","after":"3eef886f2469a4e63a4ec9b9f196c7b31775777a","ref":"refs/heads/release-7.x","pushedAt":"2024-04-19T15:53:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Add a missing semicolon in the new review request CSS.\n\nA change to switch to the ink anchor color variable lost a semicolon,\nwhich was preventing the page from loading correctly. This fixes it.\n\nTesting Done:\nWas able to look at the new review request page.\n\nReviewed at https://reviews.reviewboard.org/r/13739/","shortMessageHtmlLink":"Add a missing semicolon in the new review request CSS."}},{"before":"320a4cd30b887b7ea94085f889c1058c6c640b57","after":"f58541ce610ec3f4760b677715b6f4b48ca42c7c","ref":"refs/heads/release-7.x","pushedAt":"2024-04-18T05:36:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Modernize CommentIssueManager for performance, bug fixes, usability.\n\n`CommentIssueManager` was one of the earliest classes introduced when we\nmoved to Backbone. It had some usability flaws in terms of how its APIs\nworked, and some performance flaws in its way of notifying callers of\nissue status changes.\n\nIt also had a major caching bug where two comments of different types\nbut sharing the same ID would be seen as identical in the cache. This\ncould lead to issues setting and checking comment state. We had a bug\naround this, and fixed a symptom around it, but did not identify this\ncause beforehand.\n\nThis new version is ported to Spina and TypeScript and does the\nfollowing:\n\n* It avoids the caching bug by having a more specific cache key.\n\n* It includes new functions for accessing objects, which include\n  options-based parameters instead of positional parameters to help with\n  typing, readability, and extensibility. The old methods are\n  deprecated.\n\n* Callers can now listen to comment-specific events, instead of having\n  to listen for and check every single comment tracked in the manager.\n  This is done via a new `issueStatusUpdated:<type>:<id>` event, which\n  provides an object-based payload.\n\n* The old `issueStatusUpdated` still exists, but is also now replaced\n  with a new `anyIssueStatusUpdated` with an object-based payload as\n  well.\n\nSome typing changes to `BaseComment` and `Review` have been updated to\nmake some arguments optional. These were technically optional, but not\ntyped that way. Since those impacted typing here, they're being changed\naccordingly.\n\nTesting Done:\nUnit tests pass.\n\nMade use of some of this in an in-progress change.\n\nReviewed at https://reviews.reviewboard.org/r/13712/","shortMessageHtmlLink":"Modernize CommentIssueManager for performance, bug fixes, usability."}},{"before":"f9b5d46a420e4f0c30f7c3cc411e2f3d65b7c7ef","after":"320a4cd30b887b7ea94085f889c1058c6c640b57","ref":"refs/heads/release-7.x","pushedAt":"2024-04-18T02:38:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add a mobile view for the diff viewer.\n\nThis introduces a long-awaited mobile view for the diff viewer. This is\na pure-CSS solution for viewing existing diffs in a mobile, unified diff\ndisplay, without the need for a re-render of a diff.\n\nAll diff functionality works as normally. Users can browse the diff,\nexpand, collapse, download files, make multi-line comments,\nview/navigate moved line flags, and view interdiffs (though the revision\nslider has interaction problems on mobile).\n\nOn mobile, the diff viewer is rendered as a CSS Grid, with three\ncolumns: Original line number, modified line number, and line content.\n\nThe grid's column setup provides ample room for large line numbers\n(safely up to 6 digits) before a given row's line number column\ntruncates (it will truncate on the left). This is for browsers without\nsupport for Subgrids. For those that do support Subgrids, the columns\nwill resize for the number of digits needed (and reserve less space to\nstart).\n\nInserts, deletes, and equals present the same as before, though only one\ncolumn of line content is shown. Replaces work differently, as they're\nshown in pairs of deletes and inserts, helping visualize on a\nline-by-line basis how the content has changed.\n\nThis change doesn't require any JavaScript or server-side work.\n\nThere are some queries using the modern `:has()` selector, which Firefox\ndoesn't fully support. This is just for cleaner border styling, and is\nnot detrimental. Firefox will have improved styling once this is fully\nsupported (which, according to bug reports, should be any day now).\n\nTesting Done:\nTested on Chrome, Firefox, and Safari with and witout Subgrids.\n\nTested the diff viewer on both desktop and mobile views.\n\nOn mobile, I tested move detection, commenting (single- and multi-line),\nfile downloads, move flags, expansion/collapsing, and interdiffs, with\nall kinds of mixes of inserts/deletes/replaces.\n\nReviewed at https://reviews.reviewboard.org/r/13312/","shortMessageHtmlLink":"Add a mobile view for the diff viewer."}},{"before":"48a25142fe73404e3ce5abb96c07c0b37cf89951","after":"f9b5d46a420e4f0c30f7c3cc411e2f3d65b7c7ef","ref":"refs/heads/release-7.x","pushedAt":"2024-04-18T02:38:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark and light mode support for CodeMirror and text fields.\n\nThis updates CodeMirror and textareas inside of the Text Editor\ncomponent to work in both light and dark modes.\n\nLight mode appears the same as before, but uses Ink's CSS properties for\ninputs as a base, and uses a custom selection color of light blue.\n\nDark mode uses a dark cool grey background, white text, and a dark\nviolet selection color.\n\nThese colors may be tweaked over time in Ink.\n\nThe formatting toolbar has also been tweaked to be less noisy on dark\nmode. We now use a simple, slight background instead of the Primary\nbutton color.\n\nWe have a number of places where we try to set input and CodeMirror\nstyles, but these really should be considered legacy. For now, these\nare only being set within the `rb-c-text-editor` component. Any\nsite-wide defaults for input styling will be phased out in favor of a\nthe \"auto\" theme in Ink, as those get added there.\n\nTesting Done:\nTested that text, cursors, and selections are visible with good contrast\nin light and dark modes.\n\nThere's still work to be done for syntax highlighting.\n\nReviewed at https://reviews.reviewboard.org/r/13731/","shortMessageHtmlLink":"Add dark and light mode support for CodeMirror and text fields."}},{"before":"36582ec85863ae4ae796f9b51786dda23c0d5216","after":"48a25142fe73404e3ce5abb96c07c0b37cf89951","ref":"refs/heads/release-7.x","pushedAt":"2024-04-18T02:36:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Modernize the top bar of the page.\n\nThe top bar of the page, containing the product information, search, and\nactions, has historically been a loose collection of CSS classes that\nwere a bit fragile to deal with. In the work toward dark mode, a lot was\nneeded to clean this up.\n\nThis is now a `.rb-c-topbar` component, utilizing CSS Grid for some of\nthe layout and flexbox for the rest. This gives us better control over\nboth the desktop and mobile mode layouts.\n\nThe styling now utilizes Ink CSS variables and icons, styling off the\nheader color. This gives us consistent, page-wide control over the\ncolors used in the bar.\n\nIn light mode, the colors remain the same as before. In dark mode, we\nuse a very dark grey, almost black, though pages can override this. The\ncolors here are subject to change, and is not the primary focus of this\ncommit.\n\nWhile most of the appearance remains unchanged, one change is that the\nmenu item hover colors now use the accent color. This provides a degree\nof consistency and avoids having to deal with too many color constants.\nThis overall looks quite good, and will be a standard moving forward.\n\nThe search bar also now shows an icon in all cases, which helps keep\nthat visually identifable.\n\nTesting Done:\nTested this on Chrome and Firefox in desktop and mobile modes.\n\nTested that the mobile menu, actions, and search functionality all\nworked.\n\nTested in light mode and dark mode (with theme customization).\n\nReviewed at https://reviews.reviewboard.org/r/13718/","shortMessageHtmlLink":"Modernize the top bar of the page."}},{"before":"14bf161398ff54619d904ce75546f127b1d90c70","after":"36582ec85863ae4ae796f9b51786dda23c0d5216","ref":"refs/heads/release-7.x","pushedAt":"2024-04-18T02:35:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Remove the @spina decorator on abstract classes.\n\n`BaseVisibilityActionView` was decorated with `@spina`, which isn't\ntechnically allowed.\n\n`@spina` should only be applied to classes that can be instantiated. For\nabstract classes, we either want to use the parent class's Spina\ninformation or use `spinaBaseClassExtends` to define a new top-level\nclass.\n\nIt seems that, by and large, decorators can't be used with abstract\nclasses. When compiling, we get basically:\n\n```javascript\nconst foo = abstract class Foo {}\n```\n\nThis is a syntax error in JavaScript.\n\nThe reason we didn't encounter this problem before is that Babel was\nstripping out the `abstract` when it processed the TypeScript and\ncompiled to JavaScript. The TypeScript compiler leaves it in, in order\nto try to wrap it in a decorator.\n\nGoing forward, we'll need to be careful not to decorate these classes.\n\nTesting Done:\nUnit tests pass.\n\nVerified that this no longer broke the build when compiled via\nESBuild and Storybook.\n\nReviewed at https://reviews.reviewboard.org/r/13738/","shortMessageHtmlLink":"Remove the <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/spina/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/spina\">@spina</a> decorator on abstract classes."}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQaX0VAA","startCursor":null,"endCursor":null}},"title":"Activity · reviewboard/reviewboard"}