Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Wanted] Running MCMC under the prior also removes the node calibrations #463

Open
bjoelle opened this issue Apr 30, 2024 · 3 comments

Comments

@bjoelle
Copy link
Contributor

bjoelle commented Apr 30, 2024

Running the mcmc.run with underPrior = TRUE seems to remove all clamped nodes, including node calibrations (at least if node calibrations are set following this tutorial here)
I don't think this is proper behaviour as node calibrations are generally considered part of the prior - in particular this makes difficult to check the effective priors on the calibrations, which is generally good practice

@hoehna
Copy link
Member

hoehna commented Apr 30, 2024

Yes, I had such an example recently too. This is a bit tricky given the way how node calibrations are currently setup in RevBayes.

To get around the problem, this is what you can try:

  1. Use xxx.setValue( 0.0 ) instead of xxx.clamp( 0.0 ) for the node calibrations, or
  2. Remove the dnPhyloCTMC and run the MCMC as usual.

I did the second option.

@bjoelle
Copy link
Contributor Author

bjoelle commented Apr 30, 2024

thanks, that is helpful to know !

@bredelings
Copy link
Contributor

Yeah, "remove the dnPhyloCTMC and run the MCMC as usual" seems like it corresponds more closely to what BEAST people mean by "run under the prior". What they really mean is "run without the sequence data", which is exactly what happens when you remove dnPhyloCTMC( ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants