Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Boomerang mode #159

Open
patkan opened this issue Aug 6, 2019 · 2 comments · May be fixed by #178
Open

[Feature request] Boomerang mode #159

patkan opened this issue Aug 6, 2019 · 2 comments · May be fixed by #178

Comments

@patkan
Copy link

patkan commented Aug 6, 2019

Hello,
I quite like boomerang GIFs for this type of photo. (See some links as reference to boomerang GIFs below.)
Ideally, I would imaginge this as an alternative capture state and selectable with a similar mechanic as in #158.
@reuterbal what do you think of this feature? In terms of hardware at least the pi camera should be able to supply a video.

If you could give me some pointers on where to start in your codebase, I would try to prototype such a feature.

Boomerang GIF examples:
@patkan
Copy link
Author

patkan commented Aug 8, 2019

I have read a bit through your code and I think the easiest way of adding this feature without making the existing states more complex is adding another path in the state machine. I would add another button to the IdleState-Frame and then transition into another set of states for this feature. I would try to get back into the existing states into the Postprocessing in order to not duplicate these states.

The effect itself is done easily: I have to capture a list of frames and then append the frames in reverse order to this list. Pillow can save this set of frames into GIFs.

I will try to find some time to add the states. If you think this should be implemented differently (by reusing more of the existing states), just tell me.

@patkan
Copy link
Author

patkan commented Aug 20, 2019

Just for your information: I am prototyping this feature in this branch: master...patkan:feature-boomerang-gif and will create a Pull Request if I manage to put something relevant together.

@patkan patkan linked a pull request Sep 10, 2019 that will close this issue
Open
@patkan patkan mentioned this issue Nov 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add feature boomerang gif patkan/photobooth
1 participant
@patkan