Support for reactified zoteropane

[retorquere]

@dstillman, @adomasven, in _renderCell, must I always return a span with two subspans, with those classnames? or can I just return a single span with className cell ${column.className} cell-text?

[adomasven]

@dstillman, @adomasven, in _renderCell, must I always return a span with two subspans, with those classnames? or can I just return a single span with className cell ${column.className} cell-text?

If you just want the text you only need to override Item.getField(). You override _renderCell() if you need to perform custom cell styling and rendering. You can look for rendering functions in zotero's itemTree.jsx and virtualized-table.jsx to get an idea for what's going on there.

Which of the css changes in the scite PR are relevant to all plugins rather than specifically to scite?

If you're just doing text in your column you don't need any additional css. Otherwise add styling as you see fit to customize BBT's cells.

[dstillman]

No, Zotero.Notifier.trigger('refresh', 'item', [item ids]);

[adomasven]

Dan meant Zotero.Notifier.trigger('refresh', 'item', [item ids]) which would be the most appropriate, but refreshAndMaintainSelection() is fine if you need to update the row data for every row.

[retorquere]

For that I'd have to collect the currently visible item ids. How would I do this?

[adomasven]

Since you need to refresh all visible rows it's probably more appropriate to just call refreshAndMaintainSelection(). The notifier is more intended for individual items. And to get the displayed rows you'd need to access private properties on the itemsView, which would the defeat the purpose of using "the more appropriate API call".

[retorquere]

Then the current build should do it. I'm awaiting feedback from users, but for me it works.

[retorquere]

I'm currently hitting

error log

JavaScript error: chrome://zotero/content/xpcom/data/itemFields.js, line 280: Error: Invalid field 'undefined' for base field
console.error: "The above error occurred in the <VirtualizedTable> component:\n    in VirtualizedTable (created by Context.Consumer)\n    in injectIntl(VirtualizedTable) (created by ForwardRef)\n    in ForwardRef (created by ItemTree)\n    in ItemTree\n    in IntlProvider\n\nReact will try to recreate this component tree from scratch using the error boundary you provided, ItemTree."
zotero(3)(+0000039): ItemTree: React threw an error

zotero(1)(+0000000): Error: An error was thrown inside one of your components, but React doesn't know what it was. This is likely due to browser flakiness. React does its best to preserve the "Pause on exceptions" behavior of the DevTools, which requires some DEV-mode only tricks. It's possible that these don't work in your browser. Try triggering the error in production mode, or switching to a modern browser. If you suspect that this is actually an issue with React, please file an issue.

    invokeGuardedCallbackDev@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:240:21
    invokeGuardedCallback@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:286:5
    commitRootImpl@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:22676:11
    unstable_runWithPriority@resource://zotero/loader.jsm -> resource://zotero/react.js:2685:14
    runWithPriority$1@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:11174:12
    commitRoot@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:22516:5
    finishSyncRender@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:21942:5
    performSyncWorkOnRoot@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:21928:9
    flushSyncCallbackQueueImpl/<@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:11224:26
    unstable_runWithPriority@resource://zotero/loader.jsm -> resource://zotero/react.js:2685:14
    runWithPriority$1@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:11174:12
    flushSyncCallbackQueueImpl@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:11219:9
    flushSyncCallbackQueue@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:11207:5
    scheduleUpdateOnFiber@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:21334:11
    enqueueForceUpdate@resource://zotero/loader.jsm -> resource://zotero/react-dom.js:12813:7
    Component.prototype.forceUpdate@resource://zotero/loader.jsm -> resource://zotero/react.js:576:5
    clearItemsPaneMessage/<@chrome://zotero/content/itemTree.js:3497:576
    clearItemsPaneMessage@chrome://zotero/content/itemTree.js:3497:553
    changeCollectionTreeRow@chrome://zotero/content/itemTree.js:3583:198

The changes for my react-compatibe branch sit here BTW.

[adomasven]

I've added a comment here for what the issue there is. 04df6e6#r55605726

[retorquere]

In

 icon.className = 'icon icon-bg cell-icon'

what stylesheet are these picking icons from?

[adomasven]

In

 icon.className = 'icon icon-bg cell-icon'

what stylesheet are these picking icons from?

These are default classes from Zotero, we use those to style our own icons (item type, tags, etc). See https://github.com/zotero/zotero/blob/cbbff600a60c9e7a7407d6f2e4053309bf28b872/scss/components/_icons.scss
Scite icons are set in their .css file, and Zotero sets them inline in https://github.com/zotero/zotero/blob/67d9e87c55dfbbb4ced8c4dbe25c2a6ea09f44f0/chrome/content/zotero/components/icons.jsx

[retorquere]

I think I have now covered all changes mentioned in scitedotai/scite-zotero-plugin#26. @dstillman, @adomasven , super thanks for navigating me through this. It's a great weight off my shoulder that this went so smoothly.

[adomasven]

Great! Thanks for taking the time to do this, a lot of Zotero users rely on BBT and this was very short notice.

[retorquere]

Is the ZoteroPane global new to the beta, or also available in the non-beta release? I've been using Zotero.getActiveZoteroPane() but I wondered for a long time whether there could be more than one in the post-firefox world.

[dstillman]

Not new — that's been around forever.

And yes, there could be more than one, but since that's not officially possible at the moment (aside from a weird hack on macOS), it's not something we've spent much time thinking about.

[dstillman]

The main difference is just that ZoteroPane exists on the window, but Zotero.getActiveZoteroPane() is available to XPCOM code.