{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":47289629,"defaultBranch":"main","name":"enroute","ownerLogin":"restify","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-12-02T21:27:24.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6948699?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1701355264.0","currentOid":""},"activityList":{"items":[{"before":"df5f9f25149fcb248267db9d8927aba28b9a3d4e","after":"d8e54692209ee892ff97e7810b863ad32afbe587","ref":"refs/heads/snyk-fix-e256e3b961b76c53e8f597e0a40c2db4","pushedAt":"2023-11-30T14:41:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hekike","name":"Peter Marton","path":"/hekike","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1764512?s=80&v=4"},"commit":{"message":"fix: package.json to reduce vulnerabilities\n\nThe following vulnerabilities are fixed with an upgrade:\n- https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116","shortMessageHtmlLink":"fix: package.json to reduce vulnerabilities"}},{"before":null,"after":"df5f9f25149fcb248267db9d8927aba28b9a3d4e","ref":"refs/heads/snyk-fix-e256e3b961b76c53e8f597e0a40c2db4","pushedAt":"2023-11-30T14:41:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hekike","name":"Peter Marton","path":"/hekike","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1764512?s=80&v=4"},"commit":{"message":"6.1.0","shortMessageHtmlLink":"6.1.0"}},{"before":"1de013f94c2f53096da9b19e7ecee057fd841053","after":"eb122533653e47a1073e28ba2e841f78636258a8","ref":"refs/heads/main","pushedAt":"2023-10-30T23:32:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"josephharrington","name":"Joey Harrington","path":"/josephharrington","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1109303?s=80&v=4"},"commit":{"message":"6.1.3","shortMessageHtmlLink":"6.1.3"}},{"before":"a30a53dfa95b5e3c567beb25c71060e8cedbe93e","after":null,"ref":"refs/heads/dont-hide-errors","pushedAt":"2023-09-06T00:23:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"josephharrington","name":"Joey Harrington","path":"/josephharrington","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1109303?s=80&v=4"}},{"before":"d69f0740ab5ece07f82838af3e9bd585ed30cf4e","after":"1de013f94c2f53096da9b19e7ecee057fd841053","ref":"refs/heads/main","pushedAt":"2023-09-06T00:23:43.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"josephharrington","name":"Joey Harrington","path":"/josephharrington","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1109303?s=80&v=4"},"commit":{"message":"Merge pull request #29 from restify/dont-hide-errors","shortMessageHtmlLink":"Merge pull request #29 from restify/dont-hide-errors"}},{"before":null,"after":"a30a53dfa95b5e3c567beb25c71060e8cedbe93e","ref":"refs/heads/dont-hide-errors","pushedAt":"2023-08-28T00:58:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"josephharrington","name":"Joey Harrington","path":"/josephharrington","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1109303?s=80&v=4"},"commit":{"message":"fix: don't obscure errors when multiple routes fail to import\n\nThe newer version of `vasync` (upgraded in this lib in 6.1.1) has a worse\nerror message when a pipeline callback is invoked multiple times. Now it\ngives the obscure `AssertionError: idx should be equal to ndone`.\n\nThe reason the pipeline callback was being called multiple times was due\nto `install` logic doing route handler imports in a `lodash.forEach`\nloop. The logic would catch the exception, then `return cb1(err)`, but\nthe return was only for the current `forEach` iteration, so was\nequivalent to a `continue` instead of terminating with an error.\n\nSo if multiple route source files failed to import, we would end up\ncalling the pipeline callback with an error multiple times. The `vasync`\nassertion error would then obscure the original error, making these much\nharder to debug. We'd commonly see this if multiple route handlers both\ndepended on some common helper file which was missing or had an error in\nit.\n\nThis replaces the `forEach` loops with `for ... of` loops, so that when\nit returns and calls the pipeline callback, it now will terminate the\nloop.\n\nThis also fixes some tests that were not testing what they claimed to.\nThe tests were failing because the config was malformed, not because of\nthe intended error states. I deleted one test because this lib actually\ndoes not even throw an error in that case.","shortMessageHtmlLink":"fix: don't obscure errors when multiple routes fail to import"}},{"before":"df5f9f25149fcb248267db9d8927aba28b9a3d4e","after":"3be2d690739ffe2b29dae56b118b80531ad72efb","ref":"refs/heads/snyk-fix-c03444a46fdae9e6058769b43d660c3a","pushedAt":"2023-06-22T01:21:05.854Z","pushType":"push","commitsCount":1,"pusher":{"login":"hekike","name":"Peter Marton","path":"/hekike","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1764512?s=80&v=4"},"commit":{"message":"fix: package.json to reduce vulnerabilities\n\nThe following vulnerabilities are fixed with an upgrade:\n- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795","shortMessageHtmlLink":"fix: package.json to reduce vulnerabilities"}},{"before":null,"after":"df5f9f25149fcb248267db9d8927aba28b9a3d4e","ref":"refs/heads/snyk-fix-c03444a46fdae9e6058769b43d660c3a","pushedAt":"2023-06-22T01:21:04.898Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hekike","name":"Peter Marton","path":"/hekike","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1764512?s=80&v=4"},"commit":{"message":"6.1.0","shortMessageHtmlLink":"6.1.0"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADvCUVPQA","startCursor":null,"endCursor":null}},"title":"Activity ยท restify/enroute"}