-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid environment variable values silently ignored #4759
Comments
This is unfortunately rather complex to properly fix. Currently, environment variables are parsed inside
Avoiding these corner cases, however, requires restructuring how all commands are defined. And I'm not yet sure how a correct implementation would look like. |
Hey @MichaelEischer We enforce that all backend configurations must implement this method to read any required environment variables. Do you think something similar can be done for the Command options, where we can enforce an order of reading environment variables, command options and a validate function? |
Adding something similar for the global options should be relatively easy. Extending that to more commands in a clean way isn't that easy however. While we could introduce some callback mess, I'd like to invert how the command setup works to get rid of all the involved global variables. We currently have global variable with the options for each command along with another global variable that holds the The clean way to implement this for the commands is to completely refactor the used pattern. The first part is that move the setup of the command flags into an As a stopgap solution we could add a |
Output of
restic version
restic 0.16.4 (v0.16.4-0-g3786536dc) compiled with go1.21.8 on linux/amd64
What backend/service did you use to store the repository?
local/any
Problem description / Steps to reproduce
restic
seems to silently ignore problems with some environment variable parameters.In my instance, the documentation wasn't clear that
RESTIC_PACK_SIZE
needed to be numeric only (and was in MB) and it silently ignoredRESTIC_PACK_SIZE=64M
and continued to use the default rather than issuing a warning or failing.It does properly warn if the problem parameter is on the command line.
Expected behavior
I would expect
restic
to warn or fail if an environment variable it is using is not valid (as long as it is not being overridden on the command line).Actual behavior
restic silently ignores problems with environment variables like
RESTIC_PACK_SIZE
.Did restic help you today? Did it make you happy in any way?
Using it in a new situation, working pretty well!
The text was updated successfully, but these errors were encountered: