Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats page does not properly display redis server #1785

Open
rs-mfurlender opened this issue Jan 5, 2022 · 4 comments
Open

Stats page does not properly display redis server #1785

rs-mfurlender opened this issue Jan 5, 2022 · 4 comments

Comments

@rs-mfurlender
Copy link

Resque.redis_id used to return Resque.redis.client.id which looks like redis://127.0.0.1:6379/0, but now it returns Resque.redis.identifier which looks like <Redis::Namespace v1.7.0 with client v4.1.4 for redis://127.0.0.1:6379/0/resque>

This causes the Redis server URL to not render properly in the stats page:

image

Is there any workaround for this?

I am using version 2.2.0.

Thanks!

@iloveitaly
Copy link
Contributor

@rs-mfurlender it looks like most of this info is sourced from redis.info:

https://github.com/resque/resque/blob/master/lib/resque/server/views/stats.erb

My guess is the data returned by the redis ruby gem has changed. Feel free to submit a PR for any improvements here.

@trapper-
Copy link

trapper- commented May 6, 2022

It just needs to be escaped properly.

@iloveitaly
Copy link
Contributor

PRs are welcome to fix this!

@mishina2228
Copy link
Contributor

#1832 and #1834 are merged, so this will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants