@obj attribute regression

[jfrolich]

This caused a bug that one of our tests caught. Is this a known breaking change or a bug? (compare 10.1 vs 11 in the playground)

https://rescript-lang.org/try?version=v10.1.2&code=FAguE8AcFMAIDMCWAbaAFATgexhiAhAQwHMQABLAIwCtZoAPUaDAO0OVgFtCBraAMRTpsuAiQBcsABTBYsAH4B9CDEkBnUBkQtiAXgD8AGhBz5yQhoCyWACaIk0G5PjIshUAeOzYAVxaJQLwBKWF0APgQhTBxmMWJQ2AAiRJAAKTUAOldiKW4+QVRo0XAiHKUVaF1EynNEw2kgxqA

[zth]

This is an intentional change, and you're now encouraged to change the output using @as: #6412

The original change that caused this: #6354

[jfrolich]

Isn't the JSX3 ppx using this internally? Meaning that prepended underscored attributes don't work anymore. Or is that not affected?

[jfrolich]

Ah amazing that the @obj notation now support @as!

[jfrolich]

Hmm just confirmed this does also break JSX and @as doesn't seem to work there :|

[zth]

@mununki any ideas?

[mununki]

@jfrolich Can you share the sample code that is broken in JSX?

[jfrolich]

It's in JSX3, I managed to work around it using keyword escapes.