Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing when too many files are present with "rescript format -all" command #6685

Open
JonoPrest opened this issue Mar 18, 2024 · 0 comments

Comments

@JonoPrest
Copy link
Contributor

How does the issue come about?

We have a codegenerator tool that outputs rescript files unformatted. It then runs rescript format -all without running rescript build which happens right at the end.

We have been able to reproduce it reliably on one of our devs machines using a simple test repo:
https://github.com/enviodev/rescript-format-too-many-files

On his machine (M2 macbook), it seems to happen reliably when there are roughly > 65 .res files or so.

What we've found is that some user's shell environments will completely freeze. Even if you exit the the process, you can no longer run any other npx commands. (Even from a new shell).

Rescript versions tested:
10.1.4, 11.0.1 and 11.1.0-rc.4

Environment:
So far we've only seen this reproduce with 2 users on M1 and M2 apple silicon macbooks.

Steps to reproduce:

  1. clone the repo
  2. install node modules
  3. run rescript format -all WITHOUT building

There is a shell script in the repo for generating more files if need be for testing.

If you build the code before running rescript format -all everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant