Better handle redundant time ranges #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🐍 Python API
Deployed docs
|
jleibs
approved these changes
May 14, 2024
Comment on lines
+28
to
+35
| timelines = set() | ||
| for range in ranges: | ||
| if range.timeline in timelines: | ||
| _send_warning_or_raise( | ||
| f"Warning: Timeline {range.timeline} is listed twice in the list of visible time ranges. Only the first entry will be used.", | ||
| 1, | ||
| ) | ||
| timelines.add(range.timeline) |
There was a problem hiding this comment.
You don't actually need to make this change, but it's a useful python golf trick:
Suggested change
| timelines = set() | |
| for range in ranges: | |
| if range.timeline in timelines: | |
| _send_warning_or_raise( | |
| f"Warning: Timeline {range.timeline} is listed twice in the list of visible time ranges. Only the first entry will be used.", | |
| 1, | |
| ) | |
| timelines.add(range.timeline) | |
| for timeline in (t for t, c in collections.Counter(range.timeline for range in ranges).items() if c > 1): | |
| _send_warning_or_raise( | |
| f"Warning: Timeline {range.timeline} is listed twice in the list of visible time ranges. Only the first entry will be used.", | |
| 1, | |
| ) |
There was a problem hiding this comment.
oof. too golfy for me, having a hard time reading this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Collateral:
__hash__methods for trivial python classespixi run py-testChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.