Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection leak when rollback (reloaded) #921

Open
decebals opened this issue Feb 19, 2021 · 1 comment
Open

connection leak when rollback (reloaded) #921

decebals opened this issue Feb 19, 2021 · 1 comment

Comments

@decebals
Copy link

@npurushe
I don't think that #628 is solved.
In https://github.com/requery/requery/blob/master/requery/src/main/java/io/requery/sql/ConnectionTransaction.java#L168 it 's necessary to call close method, like in commit (see https://github.com/requery/requery/blob/master/requery/src/main/java/io/requery/sql/ConnectionTransaction.java#L150)
@decebals decebals mentioned this issue Feb 19, 2021
Closed
@nayeemzen
Copy link

Seems like a big problem - am I missing something? Doesn't this make the library unusable in production for transactional use cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@decebals @nayeemzen